Re: [PATCH v6] btrfs: Fix memory leakage in the tree-log.c

2013-10-14 Thread Geyslan Gregório Bem
2013/10/14 Josef Bacik : > On Sun, Oct 13, 2013 at 07:03:12PM -0300, Geyslan Gregório Bem wrote: >> 2013/10/11 Stefan Behrens : >> > On 10/11/2013 20:35, Geyslan G. Bem wrote: >> >> >> >> In add_inode_ref() function: >> >> >> >> Ini

Re: [PATCH v6] btrfs: Fix memory leakage in the tree-log.c

2013-10-13 Thread Geyslan Gregório Bem
2013/10/11 Stefan Behrens : > On 10/11/2013 20:35, Geyslan G. Bem wrote: >> >> In add_inode_ref() function: >> >> Initializes local pointers. >> >> Reduces the logical condition with the __add_inode_ref() return >> value by using only one 'goto out'. >> >> Centralizes the exiting, ensuring the free

Re: [PATCH v5] btrfs: Fix memory leakage in the tree-log.c

2013-10-11 Thread Geyslan Gregório Bem
2013/10/11 Stefan Behrens : > On Thu, 10 Oct 2013 19:11:22 -0300, Geyslan G. Bem wrote: >> In add_inode_ref() function: >> >> Initializes local pointers. >> >> Reduces the logical condition with the __add_inode_ref() return >> value by using only one 'goto out'. >> >> Centralizes the exiting, ensur

Re: [PATCH v3] btrfs: Fix memory leakage in the tree-log.c

2013-10-09 Thread Geyslan Gregório Bem
Josef, Thank you. Sending v4. Geyslan Gregório Bem hackingbits.com 2013/10/9 Josef Bacik : > On Wed, Oct 09, 2013 at 08:40:30PM -0300, Geyslan G. Bem wrote: >> In some cases, add_inode_ref() is returning without freeing >> the 'name' pointer. >> >> Added b

Re: [PATCH v3] btrfs: Fix memory leakage in the tree-log.c

2013-10-09 Thread Geyslan Gregório Bem
Please, Analyze [PATCH v3]. Regards, Geyslan Gregório Bem hackingbits.com 2013/10/9 Geyslan G. Bem : > In some cases, add_inode_ref() is returning without freeing > the 'name' pointer. > > Added bail out to explicitly call kfree when necessary. > > Signed-off-by:

Re: [Kernel-BR] [PATCH] btrfs: Fix memory leakage in the tree-log.c

2013-10-09 Thread Geyslan Gregório Bem
Felipe, thank you, Sending v2. Geyslan Gregório Bem hackingbits.com 2013/10/9 Felipe Pena : > Hi, > > On Wed, Oct 9, 2013 at 8:13 PM, Geyslan G. Bem wrote: >> In some cases, add_inode_ref() is returning without freeing >> the 'name' pointer. >> >> A