Re: [PATCH 2/8] blk-mq: protect completion path with RCU

complete_request); > > Hmm. Why do we need to call blk_mq_map_queue() here? Is there a chance that we end up with a _different_ hctx on completion than that one used for submission? If not, why can't we just keep a pointer to the hctx in struct request? Cheers, Hannes -- Dr. Hannes Rein

Re: [PATCH 28/45] target: use bio op accessors

On 06/06/2016 05:40 PM, Mike Christie wrote: On 06/06/2016 01:46 AM, Hannes Reinecke wrote: On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: From: Mike Christie <mchri...@redhat.com> Separate the op from the rq_flag_bits and have the target layer set/get the bio using bio_set_op

Re: [PATCH 42/45] block, fs, drivers: remove REQ_OP compat defs and related code

e/trace/events/f2fs.h | 1 - > 6 files changed, 46 insertions(+), 63 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUS

Re: [PATCH 41/45] block, drivers, fs: shrink bi_rw from long to int

ore.c | 2 +- > drivers/md/dm-flakey.c | 2 +- > drivers/md/raid5.c | 6 +++--- > fs/btrfs/check-integrity.c | 4 ++-- > fs/btrfs/inode.c | 2 +- > include/linux/blk_types.h | 2 +- > 6 files changed, 9 insertions(+), 9 deletions(-) > Reviewed-by

Re: [PATCH 40/45] block: move bio io prio to a new field

bdev; > unsigned intbi_flags; /* status, command, etc */ > int bi_error; > - unsigned long bi_rw; /* bottom bits READ/WRITE, > - * top bits priority > - */ &

Re: [PATCH 37/45] drivers: use req op accessor

d_blkdevs.c | 2 +- > drivers/nvme/host/core.c | 2 +- > drivers/nvme/host/nvme.h | 4 ++-- > drivers/scsi/sd.c | 25 ----- > 14 files changed, 43 insertions(+), 34 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com&g

Re: [PATCH 28/45] target: use bio op accessors

_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, > u32 sgl_nents, > goto fail; > > if (rw) > - bio->bi_rw |= REQ_WRITE; > + bio_set_

Re: [PATCH 25/45] bcache: use bio op accessors

++--- > drivers/md/bcache/writeback.c | 4 ++-- > 7 files changed, 31 insertions(+), 28 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 24/45] dm: use bio op accessors

On 06/05/2016 09:32 PM, mchri...@redhat.com wrote: > From: Mike Christie <mchri...@redhat.com> > > Separate the op from the rq_flag_bits and have dm > set/get the bio using bio_set_op_attrs/bio_op. > > Signed-off-by: Mike Christie <mchri...@redhat.com> >

Re: [PATCH 09/45] block discard: use bio set op accessor

ff-by: Mike Christie <mchri...@redhat.com> > --- > block/blk-lib.c| 13 +++-- > drivers/md/dm-thin.c | 2 +- > include/linux/blkdev.h | 3 ++- > 3 files changed, 10 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers

Re: [PATCH 08/45] block, fs, mm, drivers: use bio set/get op accessors

@@ int __swap_writepage(struct page *page, struct > writeback_control *wbc, > ret = -ENOMEM; > goto out; > } > - bio->bi_rw = WRITE; > + bio_set_op_attrs(bio, REQ_OP_WRITE, 0); > if (wbc->sync_mode == WB_SYNC_ALL) >

Re: [PATCH 07/45] bcache: use op_is_write instead of checking for REQ_WRITE

- > drivers/md/bcache/request.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > (Could probably folded together with the two previous patches) Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage &

Re: [PATCH 06/45] dm: use op_is_write instead of checking for REQ_WRITE

t be able to > detect a operation direction like writesame by testing if REQ_WRITE is > set. > > This has dm use the op_is_write helper which will do the right > thing. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- (Could probably be folded into t

Re: [PATCH 05/45] block, drivers, cgroup: use op_is_write helper instead of checking for REQ_WRITE

re more involved. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 S

Re: [PATCH 02/45] block: add REQ_OP definitions and helpers

d helpers in this patch will be dropped > or updated. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH 01/45] block/fs/drivers: remove rw argument from submit_bio

bio fields. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > --- Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUS

Re: [PATCH 00/42] v5: separate operations from flags in the bio/request structs

is patchset was made against linux-next from today April 13 > (git tag next-20160413). > > I put a git tree here: > https://github.com/mikechristie/linux-kernel.git > The patches are in the op branch. > A round of applause for you. For the entire series: Reviewed-by: Hannes

Re: [dm-devel] [PATCH] block: add a bi_error field to struct bio

. Signed-off-by: Christoph Hellwig h...@lst.de --- Very good improvement. Reviewed-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409