On Wed 10-05-17 08:19:50, Jeff Layton wrote:
> On Wed, 2017-05-10 at 13:48 +0200, Jan Kara wrote:
> > On Tue 09-05-17 11:49:17, Jeff Layton wrote:
> > > diff --git a/fs/file_table.c b/fs/file_table.c
> > > index 954d510b765a..d6138b6411ff 100644
> > >
>
> The new behavior is still consistent with the POSIX spec, and is more
> reliable for application developers. This patch just adds some basic
> infrastructure for doing this. Later patches will change the existing
> code to use this new infrastructure.
>
> Signed-off
Jeff Layton <jlay...@redhat.com>
The patch looks good to me. Feel free to add:
Reviewed-by: Jan Kara <j...@suse.cz>
Just two nits below:
...
> +int errseq_check_and_advance(errseq_t *eseq, errseq_t *since)
> +{
> + int err = 0;
> + errseq_t old, new;
On Tue 09-05-17 11:49:15, Jeff Layton wrote:
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
Looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
On Tue 09-05-17 11:49:14, Jeff Layton wrote:
> This ensures that we see errors on fsync when writeback fails.
>
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
> Reviewed-by: Christoph Hellwig <h...@lst.de>
Looks good to me. You can add:
Reviewed-by
On Tue 09-05-17 11:49:08, Jeff Layton wrote:
> Nothing checks its return value.
>
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
&
On Tue 09-05-17 11:49:04, Jeff Layton wrote:
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
Looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> include/linux/fs.h | 2 --
> 1 f
t allocated at the write location
>
> Signed-off-by: Goldwyn Rodrigues <rgold...@suse.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/ext4/file.c | 20 +++
ynchronous since they can block progress of the
> journalling (commit, log syncs) machinery and thus the whole filesystem.
>
> [1] https://www.spinics.net/lists/linux-ext4/msg56238.html
>
> Fixes: b685d3d65ac (block: treat REQ_FUA and REQ_PREFLUSH as synchronous)
> Cc: stable <sta..
Hello,
this series addresses a performance issue caused by commit b685d3d65ac7 "block:
treat REQ_FUA and REQ_PREFLUSH as synchronous". We know for certain this
problem significanly regresses (over 10%, in some cases up to 100%) ext4 and
btrfs for dbench4 and reaim benchmarks. Based on this I
ea5a3
Signed-off-by: Jan Kara <j...@suse.cz>
---
fs/btrfs/disk-io.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index eb1ee7b6f532..af75a9aab81e 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -3488,10
On Tue 25-04-17 06:35:13, Jeff Layton wrote:
> On Tue, 2017-04-25 at 10:17 +0200, Jan Kara wrote:
> > On Mon 24-04-17 13:14:36, Jeff Layton wrote:
> > > On Mon, 2017-04-24 at 18:04 +0200, Jan Kara wrote:
> > > > On Mon 24-04-17 09:22:49, Jeff Layton wrote:
> > &
On Mon 24-04-17 13:14:36, Jeff Layton wrote:
> On Mon, 2017-04-24 at 18:04 +0200, Jan Kara wrote:
> > On Mon 24-04-17 09:22:49, Jeff Layton wrote:
> > > This ensures that we see errors on fsync when writeback fails.
> > >
> > > Signed-off-by: Jeff Layton <j
+ b/fs/fuse/file.c
> @@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page)
> err_free:
> fuse_request_free(req);
> err:
> + mapping_set_error(page->mapping, error);
> end_page_writeback(page);
> return error;
> }
> --
>
On Mon 24-04-17 09:22:48, Jeff Layton wrote:
> launder_page is just writeback under the page lock. We still need to
> mark the mapping for errors there when they occur.
>
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
Looks good. You can add:
Reviewed-by: Jan
On Mon 24-04-17 09:22:47, Jeff Layton wrote:
> If writepage fails during a page migration, then we need to ensure that
> fsync will see it by flagging the mapping.
>
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
Looks good to me. You can add:
Reviewed-by: Jan
reporting through the mapping.
After improving the changelog you can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/dax.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> d
out the buffers. That
> will be sufficient for this case, and help other callers detect
> these errors properly as well.
>
> With that, we don't need to twiddle it in ext2.
>
> Suggested-by: Jan Kara <j...@suse.cz>
> Signed-off-by: Jeff Layton <jlay...@redhat.com>
Looks good to me. Y
REQ_IDLE flags have nothing to do with the ability of the block
layer to submit the bio without blocking...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ay be complicated in the current implementation but IMO it makes
sense to ask for such functionality (see e.g. patches for non-blocking
buffered reads that were flying around year or two ago). So I agree with
Christoph that EOPNOTSUPP is more logical.
(1 << 2) /* report extent status, e.g. FIEMAP */
> #define IOMAP_FAULT (1 << 3) /* mapping for page fault */
> #define IOMAP_DIRECT (1 << 4) /* direct I/O */
> +#define IOMAP_NOWAIT (1 << 5) /* Don't wait for writeback */
>
&g
tre-de...@lists.lustre.org
Reviewed-by: Christoph Hellwig <h...@lst.de>
Signed-off-by: Jan Kara <j...@suse.cz>
---
fs/super.c | 49
include/linux/backing-dev-defs.h | 2 +-
include/linux/fs.h | 6 +
3 files chan
Hello,
this is the third revision of the patch series which converts all embedded
occurences of struct backing_dev_info to use standalone dynamically allocated
structures. This makes bdi handling unified across all bdi users and generally
removes some boilerplate code from filesystems setting up
-by: Liu Bo <bo.li@oracle.com>
Reviewed-by: David Sterba <dste...@suse.com>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Signed-off-by: Jan Kara <j...@suse.cz>
---
fs/btrfs/ctree.h | 1 -
fs/btrfs/disk-io.c | 36 +++-
fs/btrfs/super.c | 7
On Mon 10-04-17 07:39:43, Christoph Hellwig wrote:
> On Mon, Apr 10, 2017 at 02:37:50PM +0200, Jan Kara wrote:
> > I don't understand here. Do you want that all filesystems support NOWAIT
> > direct IO?
>
> No. Per-file_system_type is way to coarse grained. All feature f
rations, rename exchange, or
O_TMPFILE support...
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu 06-04-17 11:12:02, NeilBrown wrote:
> On Wed, Apr 05 2017, Jan Kara wrote:
> >> If you want to ensure read-only files can remain cached over a crash,
> >> then you would have to mark a file in some way on stable storage
> >> *before* allowing any change.
&
:11:48AM -0400, Jeff Layton wrote:
> >> > > On Thu, 2017-03-30 at 08:47 +0200, Jan Kara wrote:
> >> > > > Because if above is acceptable we could make reported i_version to
> >> > > > be a sum
> >> > > > of "superblock crash co
.kill_sb= kill_block_super,
> - .fs_flags = FS_REQUIRES_DEV,
> + .fs_flags = FS_REQUIRES_DEV | FS_NOWAIT,
FS_NOWAIT looks a bit too generic given these are filesystem feature flags.
Can we call it FS_NOWAIT_IO?
On Sun 02-04-17 09:05:26, Dave Chinner wrote:
> On Thu, Mar 30, 2017 at 12:12:31PM -0400, J. Bruce Fields wrote:
> > On Thu, Mar 30, 2017 at 07:11:48AM -0400, Jeff Layton wrote:
> > > On Thu, 2017-03-30 at 08:47 +0200, Jan Kara wrote:
> > > > Because if above is acc
On Wed 29-03-17 13:54:31, Jeff Layton wrote:
> On Wed, 2017-03-29 at 13:15 +0200, Jan Kara wrote:
> > On Tue 21-03-17 14:46:53, Jeff Layton wrote:
> > > On Tue, 2017-03-21 at 14:30 -0400, J. Bruce Fields wrote:
> > > > On Tue, Mar 21, 2017 at 01:23:24PM -0400, Jeff
at you can see arbitrary combination of data & i_version after the
crash. We do take care to keep data and metadata in sync only when there
are security implications to that (like exposing uninitialized disk blocks)
and if not, we are as lazy as we can to improve performance...
-by: Liu Bo <bo.li@oracle.com>
Reviewed-by: David Sterba <dste...@suse.com>
Signed-off-by: Jan Kara <j...@suse.cz>
---
fs/btrfs/ctree.h | 1 -
fs/btrfs/disk-io.c | 36 +++-
fs/btrfs/super.c | 7 +++
3 files changed, 14 insertions(+), 30 deletions
tre-de...@lists.lustre.org
Signed-off-by: Jan Kara <j...@suse.cz>
---
fs/super.c | 49
include/linux/backing-dev-defs.h | 2 +-
include/linux/fs.h | 6 +
3 files changed, 56 insertions(+), 1 deletion(-)
diff --git a/fs/
Hello,
this is the second revision of the patch series which converts all embedded
occurences of struct backing_dev_info to use standalone dynamically allocated
structures. This makes bdi handling unified across all bdi users and generally
removes some boilerplate code from filesystems setting up
echanism is not really reliable. The bdi can show the device is
not congested but block layer will still block you waiting for some
resource. And for some of the stuff like tag allocation you cannot really
do a reliable check in advance so I don't think congestion checks are
really a viable altern
both blk-mq and
legacy block layer the feature will not be usable. So please work on blk-mq
support as well.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ow transfer
this information to the workqueue.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu 02-03-17 06:12:45, Matthew Wilcox wrote:
> On Thu, Mar 02, 2017 at 11:38:45AM +0100, Jan Kara wrote:
> > On Wed 01-03-17 07:38:57, Christoph Hellwig wrote:
> > > On Tue, Feb 28, 2017 at 07:46:06PM -0800, Matthew Wilcox wrote:
> > > > But what's going to
me bad accident, they can fall back to standard "blocking" AIO DIO.
So I don't see much value in teaching filemap_write_and_wait_range() about
a non-blocking mode...
Honza
--
Jan Kara <j...@suse.com>
SUSE
>
> Looks fine otherwise.
Thanks, fixed.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu 02-02-17 11:28:27, Liu Bo wrote:
> Hi,
>
> On Thu, Feb 02, 2017 at 06:34:02PM +0100, Jan Kara wrote:
> > Provide helper functions for setting up dynamically allocated
> > backing_dev_info structures for filesystems and cleaning them up on
> > superblock destruc
Hello,
this patch series converts all embedded occurences of struct backing_dev_info
to use standalone dynamically allocated structures. This makes bdi handling
unified across all bdi users and generally removes some boilerplate code from
filesystems setting up their own bdi. It also allows us to
Allocate struct backing_dev_info separately instead of embedding it
inside superblock. This unifies handling of bdi among users.
CC: Chris Mason <c...@fb.com>
CC: Josef Bacik <jba...@fb.com>
CC: David Sterba <dste...@suse.com>
CC: linux-btrfs@vger.kernel.org
Signed-off-by: Jan
tre-de...@lists.lustre.org
Signed-off-by: Jan Kara <j...@suse.cz>
---
fs/super.c | 49
include/linux/backing-dev-defs.h | 2 +-
include/linux/fs.h | 6 +
3 files changed, 56 insertions(+), 1 deletion(-)
diff --git a/fs/
On Thu 19-01-17 09:39:56, Michal Hocko wrote:
> On Tue 17-01-17 18:29:25, Jan Kara wrote:
> > On Tue 17-01-17 17:16:19, Michal Hocko wrote:
> > > > > But before going to play with that I am really wondering whether we
> > > > > need
> > > > >
d to be several years ago and we likely do not need as much
GFP_NOFS protection as we used to.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed 11-01-17 15:13:19, Miklos Szeredi wrote:
> On Wed, Jan 11, 2017 at 12:51 PM, Jan Kara <j...@suse.cz> wrote:
> > On Wed 11-01-17 11:29:28, Miklos Szeredi wrote:
> >> I know there's work on this for xfs, but could this be done in generic mm
> >> code?
> &
y bits
in the radix tree consistent if nothing else).
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gned-off-by: Michal Hocko <mho...@suse.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/ext4/acl.c | 6 +++---
> fs/ext4/extents.c | 2 +-
> fs/ext4/resi
ernel thread GFP_NOFS by the memalloc_nofs_save.
>
> Suggested-by: Jan Kara <j...@suse.cz>
> Signed-off-by: Michal Hocko <mho...@suse.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
use.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/jbd2/transaction.c | 11 +++
> include/linux/jbd2.h | 2 ++
> 2 files changed, 13 insertions(+)
>
>
l change. The main point
> of this change is to reduce explicit GFP_NOFS usage inside ext4 code to
> make the review of the remaining usage easier.
>
> Signed-off-by: Michal Hocko <mho...@suse.com>
Looks good to me. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
1.309453] [] kswapd+0x34f/0x980
> [ 1441.309454] [] kthread+0x10c/0x140
> [ 1441.309455] [] ret_from_fork+0x2a/0x40
> [ 1441.309455] stack backtrace:
> [ 1441.309457] CPU: 0 PID: 165 Comm: kswapd0 Tainted: G E
> 4.10.0-rt9-rt #11
> [ 1441.309457] Hardware name: MEDION MS-78
On Thu 08-12-16 08:45:39, Liu Bo wrote:
> On Thu, Dec 08, 2016 at 11:47:41AM +0100, Jan Kara wrote:
> > On Wed 07-12-16 17:15:42, Chris Mason wrote:
> > > On 12/07/2016 04:45 PM, Liu Bo wrote:
> > > >This has implemented DAX support for btrfs with nocow and sin
s.linux-foundation.org. Is it not active
> anymore?
No sure about the current state but usually it gets populated by the
selected attendees each year.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscrib
tually XFS
supports that (with its real-time devices) just fine - your ->iomap_begin()
returns a <device, blocknumber> pair and that should be all that's needed,
no?
Honza
introduce NR_METADATA_BYTES so we can keep track of the total amount of
> pages used for metadata on the system. This is also needed so things like
> dirty
> throttling know that this is dirtyable memory as well and easily reclaimed.
>
> Signed-off-by: Josef Bacik <jba...@fb.com
ons can get skewed.
Other than that the patch looks good to me.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon 12-09-16 10:46:56, Dave Chinner wrote:
> On Fri, Sep 09, 2016 at 10:17:43AM +0200, Jan Kara wrote:
> > On Mon 22-08-16 13:35:01, Josef Bacik wrote:
> > > Provide a mechanism for file systems to indicate how much dirty metadata
> > > they
> > > are ho
s.h b/include/linux/fs.h
> index f3f0b4c8..c063ac6 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -1430,6 +1430,8 @@ struct super_block {
>
> spinlock_t s_inode_wblist_lock;
> struct list_heads_inodes_wb;/* writeback i
writeback.
> *
> * Caller must hold lock_page_memcg().
...
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 374d95d..fb3eb62 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -3714,7 +3714,8 @@ static unsigned long node_pagecache_reclaimable(struct
> pglist_data *pgdat)
>
> /* If we
I have to think how to
do that best.
Honza
--
Jan Kara <j...@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed 10-08-16 10:27:33, Jan Kara wrote:
> On Tue 09-08-16 15:08:26, Josef Bacik wrote:
> > The only reason we pass in the mapping is to get the inode in order to see
> > if
> > writeback cgroups is enabled, and even then it only checks the bdi and a
>
ba...@fb.com>
The patch looks good. You can add:
Reviewed-by: Jan Kara <j...@suse.cz>
Honza
> ---
> fs/btrfs/disk-io.c | 4 ++--
> fs/btrfs/file.c | 3 ++-
> fs/btrfs/ioctl.c|
bdi_cap_writeback_dirty(wb->bdi)
>
> So we call locked_inode_to_wb_and_lock_list, and then get the
> bdi_writeback->bdi,
> which actually is null. As a matter of fact the whole struct bdi_writeback is
> null
> (not the pointer to it). Is this possible to stem from the same i
parts will be dropped
in the next merge window anyway so it doesn't really matter.
You can add:
Reviewed-by: Jan Kara j...@suse.com
Honza
Signed-off-by: Michal Hocko mho...@suse.com
---
fs/jbd/transaction.c | 11
add:
Reviewed-by: Jan Kara j...@suse.com
Honza
Signed-off-by: Michal Hocko mho...@suse.com
---
fs/ext4/mballoc.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4
On Thu 21-05-15 11:09:55, Kent Overstreet wrote:
On Thu, May 21, 2015 at 06:54:53PM +0200, Jan Kara wrote:
On Wed 20-05-15 18:04:40, Kent Overstreet wrote:
Yeah. I never figured out a sane way to migrate pages and keep
everything
else happy. Daniel Phillips is having a go at page
that checksums the data before and after the IO
and
complains loudly if the checksums don't match. Dunno what we can do for reads.
Thoughts?
Honza
--
Jan Kara j...@suse.cz
SUSE Labs, CR
--
To unsubscribe from this list: send the line
On Fri 28-11-14 13:14:21, Ted Tso wrote:
On Fri, Nov 28, 2014 at 06:23:23PM +0100, Jan Kara wrote:
Hum, when someone calls fsync() for an inode, you likely want to sync
timestamps to disk even if everything else is clean. I think that doing
what you did in last version:
dirty = inode
On Thu 27-11-14 15:19:54, Ted Tso wrote:
On Thu, Nov 27, 2014 at 02:14:21PM +0100, Jan Kara wrote:
Looking into the code your patch I'd prefer to do something like:
* add support for I_DIRTY_TIME in __mark_inode_dirty() - update_time will
call __mark_inode_dirty() with this flag if any
On Thu 27-11-14 18:00:16, Ted Tso wrote:
On Thu, Nov 27, 2014 at 02:14:21PM +0100, Jan Kara wrote:
* change queue_io() to also call
moved += move_expired_inodes(wb-b_dirty_time, wb-b_io, time +
24hours)
For this you need to tweak move_expired_inodes() to take pointer
() when -write_time is set (note the
return, I missed it on the first reading) which looks sensible to me.
Honza
--
Jan Kara j...@suse.cz
SUSE Labs, CR
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body
-s_op-write_inode)
+ mark_inode_dirty_sync(inode);
+ goto retry;
+ }
+ iput_final(inode);
}
}
EXPORT_SYMBOL(iput);
Honza
--
Jan Kara j...@suse.cz
On Thu 27-11-14 14:27:52, Jan Kara wrote:
On Thu 27-11-14 10:35:37, Dave Chinner wrote:
On Wed, Nov 26, 2014 at 04:10:44PM -0700, Andreas Dilger wrote:
On Nov 26, 2014, at 3:48 PM, Dave Chinner da...@fromorbit.com wrote:
On Wed, Nov 26, 2014 at 05:23:56AM -0500, Theodore Ts'o wrote
;
if (mval == 1)
ret_inode = inode;
goto out;
}
out:
spin_unlock(inode_hash_lock);
return ret_inode;
}
EXPORT_SYMBOL(find_inode_nowait);
Comments?
- Ted
--
Jan Kara j...@suse.cz
SUSE
.
Honza
--
Jan Kara j...@suse.cz
SUSE Labs, CR
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
) and this makes it
twice as bad) so I'd prefer to do this if possible.
Honza
--
Jan Kara j...@suse.cz
SUSE Labs, CR
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara j...@suse.cz
SUSE Labs, CR
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
(find_active_inode_nowait);
+
Please move this function definition into a separate patch so that it
isn't hidden in an ext4-specific patch. Otherwise it looks good.
Honza
--
Jan Kara j...@suse.cz
SUSE Labs, CR
--
To unsubscribe from this list
On Tue 25-11-14 12:57:16, Ted Tso wrote:
On Tue, Nov 25, 2014 at 06:19:27PM +0100, Jan Kara wrote:
Actually, I'd also prefer to do the writing from iput_final(). My main
reason is that shrinker starts behaving very differently when you put
inodes with I_DIRTY_TIME to the LRU. See
.
- gfs2 also used generic_write_sync to implement a crude version
of fallocate. It has been switched to use an open coded variant
instead.
Signed-off-by: Christoph Hellwig h...@lst.de
Looks good. You can add:
Reviewed-by: Jan Kara j...@suse.cz
read and we can bump it up. We can possibly add another feedback
into the readahead code to tune actualy readahead size depending on device
speed but we'd have to research exactly what algorithm would work best.
Honza
--
Jan Kara j
.
Honza
Signed-off-by: Theodore Ts'o ty...@mit.edu
Cc: linux-fsde...@vger.kernel.org
Cc: Christoph Hellwig h...@infradead.org
Cc: Artem Bityutskiy dedeki...@gmail.com
Cc: Adrian Hunter adrian.hun...@intel.com
Cc: Evgeniy Dushistov dushis...@mail.ru
Cc: Jan Kara
On Sun 01-12-13 03:59:05, Christoph Hellwig wrote:
Factor out the code to get an ACL either from the inode or disk from
check_acl, so that it can be used elsewhere later on.
Signed-off-by: Christoph Hellwig h...@lst.de
Looks good. You can add:
Reviewed-by: Jan Kara j...@suse.cz
On Sun 01-12-13 03:59:04, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
Looks good. You can add:
Reviewed-by: Jan Kara j...@suse.cz
Honza
---
fs/reiserfs/xattr_acl.c | 20 ++--
1 file
On Sun 01-12-13 03:59:06, Christoph Hellwig wrote:
This will allow moving all the Posix ACL handling into the VFS and clean
up tons of cruft in the filesystems.
Looks good. Btw I'd merge this with the following patch... Anyway:
Reviewed-by: Jan Kara j...@suse.cz
On Sun 01-12-13 03:59:07, Christoph Hellwig wrote:
With the -set_acl inode operation we can implement the Posix ACL
xattr handlers in generic code instead of duplicating them all
over the tree.
Looks good. You can add:
Reviewed-by: Jan Kara j...@suse.cz
On Sun 01-12-13 03:59:08, Christoph Hellwig wrote:
Rename the current posix_acl_chmod to __posix_acl_chmod and add
a fully featured ACL chmod helper that uses the -set_acl inode
operation.
Looks good. You can add:
Reviewed-by: Jan Kara j...@suse.cz
On Sun 01-12-13 03:59:11, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
Looks good. You can add:
Reviewed-by: Jan Kara j...@suse.cz
Honza
---
fs/ext2/acl.c | 176
On Sun 01-12-13 03:59:16, Christoph Hellwig wrote:
Signed-off-by: Christoph Hellwig h...@lst.de
Looks good. You can add:
Reviewed-by: Jan Kara j...@suse.cz
Honza
---
fs/reiserfs/acl.h |4 +-
fs/reiserfs/file.c
?
Honza
--
Jan Kara j...@suse.cz
SUSE Labs, CR
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
struct nfs_pgio_header *header = data-header;
--
1.8.4.rc3
--
To unsubscribe from this list: send the line unsubscribe linux-fsdevel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Jan Kara j
on the ext2 side needs updating callers
and (maybe) the library interfaces. We'll fix it on the convert side for
now.
CC: Jan Kara j...@suse.cz
Signed-off-by: David Sterba dste...@suse.cz
---
convert.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/convert.c b
on the ext2 side needs updating callers
and (maybe) the library interfaces. We'll fix it on the convert side for
now.
CC: Jan Kara j...@suse.cz
Signed-off-by: David Sterba dste...@suse.cz
Yes, now the patch looks OK to me
. Thanks! You can add:
Reviewed-by: Jan Kara j...@suse.cz
BTW, since changes to filesystems are minimal, maybe Fengguang can take
the patch through his writeback tree? Fengguang?
Honza
Signed-off-by: Miao Xie mi
...@oracle.com
Signed-off-by: Jan Kara j...@suse.cz
---
fs/btrfs/disk-io.c |3 ---
fs/btrfs/file.c|3 ++-
fs/btrfs/inode.c |6 +-
fs/btrfs/transaction.c |7 +++
4 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk
When mnt_want_write() starts to handle freezing it will get a full lock
semantics requiring proper lock ordering. So push mnt_want_write() call
consistently outside of i_mutex.
CC: Chris Mason chris.ma...@oracle.com
CC: linux-btrfs@vger.kernel.org
Signed-off-by: Jan Kara j...@suse.cz
---
fs
When mnt_want_write() starts to handle freezing it will get a full lock
semantics requiring proper lock ordering. So push mnt_want_write() call
consistently outside of i_mutex.
CC: Chris Mason chris.ma...@oracle.com
CC: linux-btrfs@vger.kernel.org
Signed-off-by: Jan Kara j...@suse.cz
---
fs
101 - 200 of 246 matches
Mail list logo
