Re: [PATCH v4 21/28] cxl/extent: Process DCD events and realize region extents

2024-10-09 Thread Li, Ming4
On 10/10/2024 3:49 AM, Ira Weiny wrote: > Li, Ming4 wrote: >> On 10/8/2024 7:16 AM, ira.we...@intel.com wrote: >>> From: Navneet Singh >>> [snip] >>> +static int cxl_send_dc_response(struct cxl_memdev_state *mds, int opcode, >>> +

Re: [PATCH v4 21/28] cxl/extent: Process DCD events and realize region extents

2024-10-08 Thread Li, Ming4
On 10/8/2024 7:16 AM, ira.we...@intel.com wrote: > From: Navneet Singh > > A dynamic capacity device (DCD) sends events to signal the host for > changes in the availability of Dynamic Capacity (DC) memory. These > events contain extents describing a DPA range and meta data for memory > to be adde

Re: [PATCH v3 17/25] cxl/core: Return endpoint decoder information from region search

2024-09-03 Thread Li, Ming4
On 8/16/2024 10:44 PM, Ira Weiny wrote: > cxl_dpa_to_region() finds the region from a tuple. > The search involves finding the device endpoint decoder as well. > > Dynamic capacity extent processing uses the endpoint decoder HPA > information to calculate the HPA offset. In addition, well behaved

Re: [PATCH v3 16/25] cxl/mem: Configure dynamic capacity interrupts

2024-09-03 Thread Li, Ming4
On 8/16/2024 10:44 PM, ira.we...@intel.com wrote: > From: Navneet Singh > > Dynamic Capacity Devices (DCD) support extent change notifications > through the event log mechanism. The interrupt mailbox commands were > extended in CXL 3.1 to support these notifications. Firmware can't > configure D

Re: [PATCH v3 15/25] cxl/pci: Factor out interrupt policy check

2024-09-03 Thread Li, Ming4
On 8/16/2024 10:44 PM, Ira Weiny wrote: > Dynamic Capacity Devices (DCD) require event interrupts to process > memory addition or removal. BIOS may have control over non-DCD event > processing. DCD interrupt configuration needs to be separate from > memory event interrupt configuration. > > Facto

Re: [PATCH v3 14/25] cxl/events: Split event msgnum configuration from irq setup

2024-09-03 Thread Li, Ming4
On 8/16/2024 10:44 PM, Ira Weiny wrote: > Dynamic Capacity Devices (DCD) require event interrupts to process > memory addition or removal. BIOS may have control over non-DCD event > processing. DCD interrupt configuration needs to be separate from > memory event interrupt configuration. > > Split

Re: [PATCH v3 12/25] cxl/region: Refactor common create region code

2024-09-03 Thread Li, Ming4
On 8/16/2024 10:44 PM, Ira Weiny wrote: > create_pmem_region_store() and create_ram_region_store() are identical > with the exception of the region mode. With the addition of DC region > mode this would end up being 3 copies of the same code. > > Refactor create_pmem_region_store() and create_ram_

Re: [PATCH v3 08/25] cxl/region: Add dynamic capacity decoder and region modes

2024-09-03 Thread Li, Ming4
On 8/16/2024 10:44 PM, ira.we...@intel.com wrote: > From: Navneet Singh > > One or more decoders each pointing to a Dynamic Capacity (DC) partition > form a CXL software region. The region mode reflects composition of > that entire software region. Decoder mode reflects a specific DC > partition

Re: [PATCH v3 07/25] cxl/core: Separate region mode from decoder mode

2024-09-02 Thread Li, Ming4
On 8/16/2024 10:44 PM, ira.we...@intel.com wrote: > From: Navneet Singh > > Until now region modes and decoder modes were equivalent in that both > modes were either PMEM or RAM. The addition of Dynamic > Capacity partitions defines up to 8 DC partitions per device. > > The region mode is thus no

Re: [PATCH v3 05/25] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)

2024-09-02 Thread Li, Ming4
On 8/16/2024 10:44 PM, ira.we...@intel.com wrote: > From: Navneet Singh > > Per the CXL 3.1 specification software must check the Command Effects > Log (CEL) for dynamic capacity command support. > > Detect support for the DCD commands while reading the CEL, including: > > Get DC Config >

Re: [PATCH v3 04/25] cxl/pci: Delay event buffer allocation

2024-09-02 Thread Li, Ming4
On 8/16/2024 10:44 PM, Ira Weiny wrote: > The event buffer does not need to be allocated if something has failed in > setting up event irq's. > > In prep for adjusting event configuration for DCD events move the buffer > allocation to the end of the event configuration. > > Reviewed-by: Davidlohr B

Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents

2024-09-02 Thread Li, Ming4
On 8/16/2024 10:44 PM, ira.we...@intel.com wrote: > From: Navneet Singh > > A dynamic capacity device (DCD) sends events to signal the host for > changes in the availability of Dynamic Capacity (DC) memory. These > events contain extents describing a DPA range and meta data for memory > to be add

Re: [PATCH v3 13/25] cxl/region: Add sparse DAX region support

2024-09-02 Thread Li, Ming4
On 8/16/2024 10:44 PM, ira.we...@intel.com wrote: > From: Navneet Singh > > Dynamic Capacity CXL regions must allow memory to be added or removed > dynamically. In addition to the quantity of memory available the > location of the memory within a DC partition is dynamic based on the > extents off