Re: [PATCH]Btrfs:Fix discard semantic

ved_extent() 5, Discard sectors before updating the free space cache, otherwise, FTL will destroy file system data. -- Thanks & Best Regards Liu Hui -- --- extent-tree-old.c 2009-01-03 23:01:30.0 +0800 +++ extent-tree.c 2009-01-03 22:58:55.0 +0800 @@

Re: A bug with multiple devices?

mmunication, you are hereby notified that any dissemination, distribution > or copying hereof is strictly prohibited. If you have received this > communication in error, please notify me by reply e-mail, permanently delete > this communication from your system, and destroy

[PATCH]Btrfs:Fix discard semantic

ent_commit() when committing transaction. 3, Remove discarding from free_extents() 4, Add discard interface into btrfs_free_reserved_extent() 5, Discard sectors before updating the free space cache, otherwise, FTL will destroy file system data. -- Thanks & Best Regards Liu Hui -- diff --git a/e

[PATCH]Fix compile error in quick-test.c of btrfs progs

Hi, This patch fix compiler error in quick-test.c -- Thanks & Best Regards Liu Hui -- diff --git a/quick-test.c b/quick-test.c index 44c2318..351c706 100644 --- a/quick-test.c +++ b/quick-test.c @@ -18,6 +18,7 @@ #include #include +#include #include "kerncompat.h" #include

[PATCH]Fix typo in clear_state_cb

Hi, In clear_state_cb, we should check 'tree->ops->clear_bit_hook' instead of 'tree->ops->set_bit_hook'. -- Thanks & Best Regards Liu Hui -- diff --git a/extent_io.c b/extent_io.c index 25ce2d1..0bf7684 100644 --- a/extent_io.c +++ b/extent_io.c @@ -340,7

Re: Notes on support for multiple devices for a single filesystem

lesystem at all? Why not let MD take care of all this and > present a single block device to the fs layer? > > Lots of filesystems are violating this, and I'm sure the reasons for > this are good, but this document seems like a suitable place in which to > briefly decribe those

Re: [PATCH]Fix for map_private_extent_buffer to handle extent which is not page alignment

Hi, I don't know why GMAIL mix my ASCII figure, the figure for extent1 is still not correct. Here is the newest one, hope GMAIL works. |-extent1-| +-++-+ |page1||page2| +-++-+ Thanks 2008/12/4 Liu Hui <[EMAIL PROTECTED]>: > There is a little problem with t

Re: [PATCH]Fix for map_private_extent_buffer to handle extent which is not page alignment

There is a little problem with the first ASCII figure, here is the new one. |-extent1-| +-++-+ |page1||page2| +-++-+ Thanks, Liu Hui 2008/12/4 Liu Hui <[EMAIL PROTECTED]>: > Hi, > Now, BTRFS only supports page alignment extent. But in > map_private_extent(), th

[PATCH]Fix for map_private_extent_buffer to handle extent which is not page alignment

tent2-| +-++-+ |page1||page2| +-++-+ -- Thanks & Best Regards Liu Hui -- diff --git a/extent_io.c b/extent_io.c index c3dfe2a..cac47d1 100644 --- a/extent_io.c +++ b/extent_io.c @@ -3426,9 +3426,11 @@ int map_private_extent_buffer(struct extent_buffer *eb, unsigned long start, ch

Re: [PATCH]Fix cow semantic in run_delalloc_nocow()

Hi chris, This is just a reminder to tell you that I found the commit message in git log, but the code has not been checked in yet. 2008/11/21 Chris Mason <[EMAIL PROTECTED]>: > On Thu, 2008-11-20 at 21:47 +0800, Liu Hui wrote: >> Ok, this is the new patch. >> > > Thank

Re: [PATH]Fix cow semantic in run_delalloc_nocow()

Ok, this is the new patch. -- Thanks & Best Regards Liu Hui -- diff --git a/inode.c b/inode.c index 2c77e09..5e3789f 100644 --- a/inode.c +++ b/inode.c @@ -1114,10 +1114,10 @@ static int run_delalloc_range(struct inode *inode, struct page *locked_page, if (btrfs_test_opt(root, NODAT

[PATH]Fix cow semantic in run_delalloc_nocow()

), it will not take cow operation. So, the cow semantic is opposite to the btrfs design. I found the problem was introduced by fallocate(), so could Yan please verify the fix? Much appreciated! -- Thanks & Best Regards Liu Hui -- diff --git a/inode.c b/inode.c index 2c77e09..5525594 100

[PATH]Some fix for batching extent insert.

Hi, When I review the code about batching extent insert, I found some code could result in problems in some corner cases. 1)In finish_current_insert(), when it finds nothing to insert and it has skipped some locked extents, it should try again to see if the locked extent is unlocked. So, it will re