btrfs fi usage crash when multiple device volume contains seed device

Hi, Chris Murphy suggested we move the discussion in this bugzilla thread: https://bugzilla.kernel.org/show_bug.cgi?id=115851 To here, the mailing list. Going to quote him to give context: "This might be better discussed on list to ensure there's congruence in dev and user expectations; and in

Re: [bug] df returns 100% used for empty mixed block group filesystem

able if metadata are exhausted >>> http://www.spinics.net/lists/linux-btrfs/msg48013.html >>> >>> Maybe some maths there are wrong in case of a mixed blockgroup filesystem. >> >> Yes it's caused by the referenced patch. The statfs has been broken for >> mixed blockgr

Re: [PATCH v4] btrfs: fix typo in btrfs_statfs()

On 04/04/16 15:45, David Sterba wrote: > On Mon, Apr 04, 2016 at 03:31:22PM +0100, Luis de Bethencourt wrote: >> Correct a typo in the chunk_mutex name to make it grepable. >> >> Since it is better to fix several typos at once, fixing the 2 more in the >> same file. &

[PATCH v4] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name to make it grepable. Since it is better to fix several typos at once, fixing the 2 more in the same file. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Hi, Sorry for sending again. Previous version had a line over 80 char

[PATCH v3] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name to make it grepable. Since it is better to fix several typos at once, fixing the 2 more in the same file. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Hi, David recommended I look around the rest of the file for other typos

[PATCH v2] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Hi, I noticed this typo while fixing bug 114281 [0]. Sending a second version because the first one didn't ammend cleanly after the latest changes in the 'for-next' branch. Thanks, Lu

[PATCH] btrfs: fix typo in btrfs_statfs()

Correct a typo in the chunk_mutex name. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- Hi, I noticed this typo while fixing bug 114281 [0]. If this type of fixes are not welcomed I could squash it into the patch for that bug. Thanks, Luis [0] https://bugzilla.kern

[PATCH v2 2/2] btrfs: avoid overflowing f_bfree

Since mixed block groups accounting isn't byte-accurate and f_bree is an unsigned integer, it could overflow. Avoid this. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Suggested-by: David Sterba <dste...@suse.com> --- Hi, Thanks to Filipe Manana for spotting a mistake

Re: [PATCH 2/2] btrfs: avoid overflowing f_bfree

On 30/03/16 22:48, Filipe Manana wrote: > On Wed, Mar 30, 2016 at 9:53 PM, Luis de Bethencourt > <lui...@osg.samsung.com> wrote: >> Since mixed block groups accounting isn't byte-accurate and f_bree is an >> unsigned integer, it could overflow. Avoid this. >> >>

[PATCH 1/2] btrfs: fix mixed block count of available space

Metadata for mixed block is already accounted in total data and should not be counted as part of the free metadata space. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Link: https://bugzilla.kernel.org/show_bug.cgi?id=114281 --- fs/btrfs/super.c | 16 +---

[PATCH 2/2] btrfs: avoid overflowing f_bfree

Since mixed block groups accounting isn't byte-accurate and f_bree is an unsigned integer, it could overflow. Avoid this. Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Suggested-by: David Sterba <dste...@suse.com> --- fs/btrfs/super.c | 5 + 1 file changed,

Re: erika

zieg...@uni-freiburg.de writes: > mi-tse, > > wie sieht's aus, haste den File runtergeladen? > > S-li Huh? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at

[RESEND PATCH 1/2] btrfs: check-integrity: Fix returned errno codes

: btrfsic_process_superblock() warn: returning -1 instead of -ENOMEM is sloppy btrfsic_read_block() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Reviewed-by: David Sterba <dste...@suse.com> --- fs/btrfs/check-integrity.c | 4 ++-- 1 file changed,

[RESEND PATCH 0/2] btrfs: Fix returned errno codes

/24/553 Luis de Bethencourt (2): btrfs: check-integrity: Fix returned errno codes btrfs: reada: Fix returned errno code fs/btrfs/check-integrity.c | 4 ++-- fs/btrfs/reada.c | 8 +--- 2 files changed, 7 insertions(+), 5 deletions(-) -- 2.5.3 -- To unsubscribe from this list

[RESEND PATCH 2/2] btrfs: reada: Fix returned errno code

: reada_add_block() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Reviewed-by: David Sterba <dste...@suse.com> --- fs/btrfs/reada.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/reada.

[PATCH v2 2/2] btrfs: reada: Fix returned errno code

: reada_add_block() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- fs/btrfs/reada.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c index 4645cd1..619f929 100644 --

[PATCH v2 0/2] btrfs: Fix returned errno codes

Hi, These two patches fix instances where -1 is used to specify a buffer allocation fail, instead of using -ENOMEM. Patch 1/2 is already reviewed by David Sterba. Luis de Bethencourt (2): btrfs: check-integrity: Fix returned errno codes btrfs: reada: Fix returned errno code fs/btrfs/check

[PATCH 0/2] btrfs: Fix returned errno codes

From: Luis de Bethencourt <l...@debethencourt.com> Hi, These two patches fix instances where -1 is used to specify a buffer allocation fail, instead of using -ENOMEM. I could merge the two patches into one if that's more appropriate. Thanks, Luis Luis de Bethencourt (2): btrfs:

[PATCH 1/2] btrfs: check-integrity: Fix returned errno codes

: btrfsic_process_superblock() warn: returning -1 instead of -ENOMEM is sloppy btrfsic_read_block() warn: returning -1 instead of -ENOMEM is sloppy Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- fs/btrfs/check-integrity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs

[PATCH 2/2] btrfs: reada: Fix returned errno code

-off-by: Luis de Bethencourt <lui...@osg.samsung.com> --- fs/btrfs/reada.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c index 4645cd1..5bfd3cd 100644 --- a/fs/btrfs/reada.c +++ b/fs/btrfs/reada.c @@ -569,7 +569,7 @@ stat