At Thu, 19 Oct 2017 17:05:18 +0800,
Qu Wenruo wrote:
>
>
>
> On 2017年10月19日 16:34, Misono, Tomohiro wrote:
> > On 2017/10/19 16:45, Satoru Takeuchi wrote:
> >> Some tools can select which superblock these commands use by "-s
> >> "
> >> o
At Thu, 19 Oct 2017 12:03:08 +0900,
satoru takeuchi wrote:
>
> Resend it since I forgot to CC linux-btrfs ML >Larkin
>
> On Oct 17, 2017, at 0:16, Larkin Lowrey
> wrote:
>
> I am unable to mount one my my filesystems. The superblock thinks
> the latest genera
Some tools can select which superblock these commands use by "-s "
option. Although this option says the valid values are 0-2, we can set 3
if filesystem is very large.
Signed-off-by: Satoru Takeuchi
---
Documentation/btrfs-check.asciidoc| 2 +-
Documentation/btrfs-restor
At Tue, 19 Sep 2017 17:14:27 +0200,
David Sterba wrote:
>
> On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote:
> > At Sun, 17 Sep 2017 14:08:40 +0100,
> > Mike Fleetwood wrote:
> > >
> > > On 17 September 2017 at 01:36, Satoru Takeuchi
> >
At Sat, 14 Oct 2017 18:19:14 +0200,
Koen Kooi wrote:
>
> Op 14-10-17 om 14:54 schreef Satoru Takeuchi:
> > It's messy to use "" to disable compression. Introduce the new value "no"
> > which can also be used for this purpose.
>
> Wouldn
At Sat, 14 Oct 2017 08:35:56 +0800,
Anand Jain wrote:
>
> At few places we could use BLK_STS_OK and BLK_STS_NOSUPP.
>
> Signed-off-by: Anand Jain
Reviewed-by: Satoru Taekeuchi
> ---
> fs/btrfs/compression.c | 3 ++-
> fs/btrfs/inode.c | 4 ++--
> fs/btrfs/volumes.c | 2 +-
> 3 file
It's messy to use "" to disable compression. Introduce the new value "no"
which can also be used for this purpose.
Signed-off-by: Satoru Takeuchi
---
Documentation/btrfs-property.asciidoc | 2 +-
props.c | 6 --
2 files changed, 5 i
At Tue, 3 Oct 2017 17:12:39 +0900,
Misono, Tomohiro wrote:
>
> This patch updates help/document of "btrfs device remove" in two points:
>
> 1. Add explanation of 'missing' for 'device remove'. This is only
> written in wikipage currently.
> (https://btrfs.wiki.kernel.org/index.php/Using_Btrfs_wit
At Sun, 08 Oct 2017 17:58:10 +0800,
Kai Hendry wrote:
>
> Hi there,
>
> My /mnt/raid1 suddenly became full somewhat expectedly, so I bought 2
> new USB 4TB hard drives (one WD, one Seagate) to upgrade to.
>
> After adding sde and sdd I started to see errors in dmesg [2].
> https://s.natalian.org
At Sat, 23 Sep 2017 10:19:26 +0900,
Satoru Takeuchi wrote:
>
> At Wed, 20 Sep 2017 15:18:43 +0900,
> Qu Wenruo wrote:
> >
> > Commit 7dfb8be11b5d ("btrfs: Round down values which are written for
> > total_bytes_size") is fixing the unaligned device size
At Wed, 20 Sep 2017 15:18:43 +0900,
Qu Wenruo wrote:
>
> Commit 7dfb8be11b5d ("btrfs: Round down values which are written for
> total_bytes_size") is fixing the unaligned device size caused by
> adding/shrinking device.
>
> It added a new WARN_ON() when device size is unaligned.
> This is fine fo
s.
>
> Signed-off-by: Liu Bo
Reviewed-by: Satoru Takeuchi
I checked all callers of the following functions and there is no leftover.
- btrfs_map_block
- btrfs_map_sblock
- __btrfs_map_block
Thanks,
Satoru
> ---
> fs/btrfs/volumes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 d
tested this patch with injecting error on ioctl() for subvol
creation/deletion.
Reviewed-by: Satoru Takeuchi
Tested-by: Satoru Takeuchi
> ---
> cmds-subvolume.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/cmds-subvolume.c b/cmds-subvolume.c
>
At Tue, 19 Sep 2017 17:14:27 +0200,
David Sterba wrote:
>
> On Mon, Sep 18, 2017 at 09:41:17AM +0900, Satoru Takeuchi wrote:
> > At Sun, 17 Sep 2017 14:08:40 +0100,
> > Mike Fleetwood wrote:
> > >
> > > On 17 September 2017 at 01:36, Satoru Takeuchi
> >
At Wed, 13 Sep 2017 11:53:35 -0400,
Ruoxin Jiang wrote:
>
> [1 ]
> Hello,
>
> We are researchers from Columbia University, New York. As part of our
> current research we have found some semantic discrepancies between
> btrfs and other popular filesystems.
>
> We have attached two cases. The fir
and lowmem mode, so we can have a clue what's going
> wrong.
>
> Reported-by: Marc MERLIN
> Signed-off-by: Qu Wenruo
> ---
> v2:
> Add prefix for each time report, as error message may make the output
> hard to understand. Suggested by Satoru.
Reviewed-by: Satoru Tak
At Sun, 17 Sep 2017 14:08:40 +0100,
Mike Fleetwood wrote:
>
> On 17 September 2017 at 01:36, Satoru Takeuchi
> wrote:
> > It's messy to use "" to disable compression. Introduce the new value "no"
> > which can also be used for this purpose.
>
ore branch, so it's
> safe to remove that subtraction.
>
> Signed-off-by: Timofey Titovets
Reviewed-by: Satoru Takeuchi
> ---
> fs/btrfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 02
At Mon, 11 Sep 2017 14:26:23 +0900,
Qu Wenruo wrote:
>
> Marc reported that "btrfs check --repair" runs much faster than "btrfs
> check", which is quite weird.
>
> This patch will add time elapsed for each major tree it checked, for
> both original mode and lowmem mode, so we can have a clue what
It's messy to use "" to disable compression. Introduce the new value "no"
which can also be used for this purpose.
Signed-off-by: Satoru Takeuchi
---
Documentation/btrfs-property.asciidoc | 2 +-
props.c | 6 --
2 files changed, 5 i
`btrfs sub set-default` succeeds to set an ID which isn't corresponding to any
fs/file tree. If such the bad ID is set to a filesystem, we can't mount this
filesystem without specifying `subvol` or `subvolid` mount options.
Signed-off-by: Satoru Takeuchi
---
fs/btrfs/ioctl.c | 4 ++
Signed-off-by: Satoru Takeuchi
---
fs/btrfs/extent-tree.c | 2 +-
fs/btrfs/super.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index e2d7e86..ea9b0d2 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
2017-03-24 20:58 GMT+09:00 David Sterba :
> On Tue, Mar 21, 2017 at 10:53:09AM +0900, Satoru Takeuchi wrote:
>> There have been some discussions about inconsistent device between
>> /proc/pid/maps and stat(2).
>>
>> http://thr3ads.net/btrfs-devel/2011/05/2346176-RFC
me/vagrant/mnt
lsof 752 root txt REG 0,44 163224
263 /home/vagrant/mnt/lsof
lsof 754 root txt REG 0,44 163224
263 /home/vagrant/mnt/lsof
===
Signed-off-by: Satoru Takeuchi
CC: Signed-off-by: Mark Fashe
On 2016/07/12 1:41, David Sterba wrote:
> On Mon, Jul 11, 2016 at 11:05:29AM +0800, Qu Wenruo wrote:
>> From: Wang Xiaoguang
>>
>> Extract cow_file_range() new parameters for both in-band dedupe and
>> subpage sector size patchset.
>>
>> This should make conflict of both patchset to minimal, and r
On 2016/06/22 0:16, Austin S. Hemmelgarn wrote:
> Currently, balance operations are run synchronously in the foreground.
> This is nice for interactive management, but is kind of crappy when you
> start looking at automation and similar things.
>
> This patch adds an option to `btrfs balance start
---
This patch can be applied to integration-20160704(2355a7e5dcdf122d1924)
---
cmds-dedupe-ib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmds-dedupe-ib.c b/cmds-dedupe-ib.c
index 342784c..dbb30ab 100644
--- a/cmds-dedupe-ib.c
+++ b/cmds-dedupe-ib.c
@@ -132,7 +132,7 @@ s
show foo
ERROR: foo is not a valid Btrfs
#
# echo $?
1
===
Signed-off-by: Satoru Takeuchi
---
cmds-filesystem.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index 88867a3..90f3c49 100644
--- a/cm
dd() back to btrfs_finish_ordered_io() to increase dedup
>> rate.
>> v5:
>> Reuse compress routine for much simpler dedup function.
>> Slightly improved performance due to above modification.
>> Fix race between dedup enable/disable
>> Fix for false ENOSPC repo
On 2016/06/21 8:30, Marc Grondin wrote:
> Hi everyone,
>
>
> I have a btrfs filesystem ontop of a 4x1tb mdraid raid5 array and I've
> been getting confusing output on metadata usage. Seems that even tho
> both data and metadata are in single profile metadata is reporting
> double the space(as if
On 2016/06/17 1:38, Chandan Rajendra wrote:
> stripesize should ideally be set to the value of sectorsize. However
> previous versions of btrfs-progs/mkfs.btrfs had set stripesize to a
> value of 4096. On machines with PAGE_SIZE other than 4096, This could
> lead to the following scenario,
>
> - /
On 2016/06/14 18:16, Hugo Mills wrote:
> On Tue, Jun 14, 2016 at 10:51:33AM +0200, David Sterba wrote:
>> On Tue, Jun 14, 2016 at 02:50:19PM +0900, Satoru Takeuchi wrote:
>>> We can set not only btrfs mount point but also any path belong to
>>> btrfs mount point as
We can set not only btrfs mount point but also any path belong to
btrfs mount point as btrfs-receive's destination.
Signed-off-by: Satoru Takeuchi
---
Documentation/btrfs-receive.asciidoc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/
Signed-off-by: Satoru Takeuchi
---
btrfs-crc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/btrfs-crc.c b/btrfs-crc.c
index c2b5f00..d433ff3 100644
--- a/btrfs-crc.c
+++ b/btrfs-crc.c
@@ -69,12 +69,14 @@ int main(int argc, char **argv)
str = argv[optind
- If -c is set, filename argument is ignored.
- Describe about -h option
Signed-off-by: Satoru Takeuchi
---
btrfs-crc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/btrfs-crc.c b/btrfs-crc.c
index 55a4c61..c2b5f00 100644
--- a/btrfs-crc.c
+++ b/btrfs-crc.c
@@ -26,10
Usage is only printed if -h option is set. However it's nice to
do it when wrong option is set or the number of argument is wrong.
Signed-off-by: Satoru Takeuchi
---
btrfs-crc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/btrfs-crc.c b/btrfs-crc.c
It's a binary built from btrfs-crc.c
Signed-off-by: Satoru Takeuchi
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitignore b/.gitignore
index a27cb0d..aaf9702 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,6 +33,7 @@ btrfs-zero-log
btrfs-corrupt-block
btrfs-s
ogs/help.c:125: first defined here
collect2: error: ld returned 1 exit status
Makefile:294: recipe for target 'btrfs-crc' failed
make: *** [btrfs-crc] Error 1
=====
Signed-off-by: Satoru Takeuchi
---
btrfs-crc.c | 4 ++--
1 file changed, 2 insert
On 2016/06/02 10:20, al wrote:
Satoru Takeuchi jp.fujitsu.com> writes:
Thank you, sir!
I wonder if you would let me have the permissions (only) of any of the files
you have inside your equivalent directory.
Here it is.
===
# ls -l /var/lib/btrfs/
total 4
-rw---. 1 r
On 2016/06/01 6:53, al wrote:
Please can someone run:
# ls -l /var/lib/ | grep btrfs
for me (and post to directly or via list as they think fit).
$ ls -l /var/lib | grep btrfs
drwxr-xr-x 1 root root 196 May 18 10:34 btrfs
===
On 2016/05/11 10:40, Qu Wenruo wrote:
Chris Mason wrote on 2016/05/10 20:37 -0400:
On Tue, May 10, 2016 at 03:19:52PM +0800, Qu Wenruo wrote:
Hi, Chris, Josef and David,
As merge window for v4.7 is coming, it would be good to hear your ideas
about the inband dedupe.
We are addressing the EN
parse_args() always set at least one parameter, 'object', for
{get,list} subcommands. In addition, it always set all three
parameters, 'object', 'name', and 'value' for set subcommand.
So the following conditions can be removed.
Signed-off-by: Sat
Since parameter is mandatory for all subcommands,
'object' is always set by parse_args()'s callers.
In addition, on setting '*name' and '*value', if 'optind < argc'
is satisfied here, they are always set by parse_args()'s callers.
Signe
props.c uses 'fprintf(stderr, "ERROR: ...")' as its error messages,
however we have generic error() function.
Signed-off-by: Satoru Takeuchi
---
props.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/props.c b/props.c
index 5b7
On 2016/04/23 16:07, Matthias Bodenbinder wrote:
Here is my newest test. The backports provide a 4.5 kernel:
kernel: 4.5.0-0.bpo.1-amd64
btrfs-tools: 4.4-1~bpo8+1
This time the raid1 is automatically unmounted after I unplug the device and it
can not be mounted while the device is mi
On 2016/04/22 14:32, Qu Wenruo wrote:
Satoru Takeuchi wrote on 2016/04/22 11:21 +0900:
On 2016/04/21 20:58, Qu Wenruo wrote:
On 04/21/2016 03:45 PM, Satoru Takeuchi wrote:
On 2016/04/21 15:23, Satoru Takeuchi wrote:
On 2016/04/20 14:17, Matthias Bodenbinder wrote:
Am 18.04.2016 um 09:22
On 2016/04/21 20:58, Qu Wenruo wrote:
On 04/21/2016 03:45 PM, Satoru Takeuchi wrote:
On 2016/04/21 15:23, Satoru Takeuchi wrote:
On 2016/04/20 14:17, Matthias Bodenbinder wrote:
Am 18.04.2016 um 09:22 schrieb Qu Wenruo:
BTW, it would be better to post the dmesg for better debug.
So here
On 2016/04/21 15:23, Satoru Takeuchi wrote:
On 2016/04/20 14:17, Matthias Bodenbinder wrote:
Am 18.04.2016 um 09:22 schrieb Qu Wenruo:
BTW, it would be better to post the dmesg for better debug.
So here we. I did the same test again. Here is a full log of what i did. It
seems to be mean
On 2016/04/20 14:17, Matthias Bodenbinder wrote:
Am 18.04.2016 um 09:22 schrieb Qu Wenruo:
BTW, it would be better to post the dmesg for better debug.
So here we. I did the same test again. Here is a full log of what i did. It
seems to be mean like a bug in btrfs.
Sequenz of events:
1. mount
>From commit c742debab11f ('btrfs-progs: fix a regression that
"property" with -t option doesn't work'), the number of arguments
is checked strictly. So the following condition never be
satisfied.
Signed-off-by: Satoru Takeuchi
---
cmds-property.c | 5 -
1 file c
On 2016/04/20 7:25, Mark Fasheh wrote:
This has been broken since Linux v4.1. We may have worked out a solution on
the btrfs list but in the meantime sending a test to expose the issue seems
like a good idea.
Signed-off-by: Mark Fasheh
---
tests/btrfs/122 | 88 ++
On 2016/04/15 10:55, Chris Murphy wrote:
Hi,
I'm realizing instead of doing 'btrfs subvolume -t' and then 'btrfs
subvolume -tr' and comparing, it would be better if -t just had a
column for whether a subvolume is ro. And maybe it's useful to know if
a subvolume is a snapshot or not (?). I'm not
/dev/sdb2
==
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to devel branch (commit: a35b7e6ee122)
---
utils.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/utils.c b/utils.c
index 75ce6ea..7e45702 100644
--- a/utils.c
+++ b/utils.c
@@ -2455,7 +2455,6 @@ int test_num_disk_v
=
* expected result
==
# btrfs inspect-internal subvolid-resolve 260 /btrfs
snap
======
Signed-off-by: Satoru Takeuchi
---
cmds-inspect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmds-inspect.c b/cmds-inspe
an if needed
--no-rescan
==
* expected result
==
# ./btrfs qgroup assign --rescan 0/260 1/261 /btrfs
#
======
Signed-off-by: Satoru Tak
Get the default subvolume of a filesystem
==
* expected result
==
# btrfs sub get-default /btrfs
ID 5 (FS_TREE)
======
Signed-off-by: Satoru Takeuch
ned-off-by: Satoru Takeuchi
---
cmds-qgroup.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/cmds-qgroup.c b/cmds-qgroup.c
index ebd66ef..4b4149d 100644
--- a/cmds-qgroup.c
+++ b/cmds-qgroup.c
@@ -44,9 +44,13 @@ static int _cmd_qgroup_assign(int assign, int argc, ch
Destroy a quota group.
==
* expected result
==
# btrfs qgroup create 1 /btrfs/sub
# btrfs qgroup destroy 1 /btrfs/sub/
======
Signed-off-by: Satoru Takeuch
trfs
label Set/get label of device.
======
Signed-off-by: Satoru Takeuchi http://vger.kernel.org/majordomo-info.html
iption of
objects and object types.
==
* expected result
==
$ ./btrfs prop list -t f /btrfs
label Set/get label of device.
======
Signed-off-by: Satoru T
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to devel branch (commit: 4685a560811a)
---
Documentation/btrfs-receive.asciidoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/btrfs-receive.asciidoc
b/Documentation/btrfs-receive.asciidoc
index
On 2016/03/14 21:23, David Sterba wrote:
On Mon, Mar 14, 2016 at 09:12:36AM +0900, Satoru Takeuchi wrote:
--- a/cmds-property.c
+++ b/cmds-property.c
@@ -379,9 +379,7 @@ static int cmd_property_get(int argc, char **argv)
char *name = NULL;
int types = 0
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to 4.5
---
fs/btrfs/ioctl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 48aee98..b474e32 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -123,10 +123,10
: btrfs device ready
Check device to see if it has all of its devices in cache for mounting
#
===
Signed-off-by: Satoru Takeuchi
---
cmds-device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmds-device.c b/cmds-device.c
index
bel /btrfs bar
# ./btrfs prop get /btrfs label
label=bar
===
Signed-off-by: Satoru Takeuchi
---
cmds-filesystem.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index 7e74e1
iption of
objects and object types.
==
* expected result
==
# btrfs prop list -t f /btrfs
label Set/get label of device
======
Signed-off-by: Sa
: 91247.41MiB
==
* expected result
==
# ./btrfs device usage -- -m /btrfs
ERROR: can't access '-m': No such file or directory
==
Signed-off-by: Satoru Takeuchi
---
Th
On 2016/03/10 6:46, Hendrik Friedel wrote:
Hello,
I intend to move this subvolume to a new device.
btrfs fi show /mnt2/Data_Store/
Label: 'Data_Store' uuid: 0ccc1e24-090d-42e2-9e61-d0a1b3101f93
Total devices 1 FS bytes used 47.93GiB
devid1 size 102.94GiB used 76.03GiB path
'/dev/sdb'
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to devel (commit: 5d038a7ed212)
---
cmds-device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/cmds-device.c b/cmds-device.c
index 94ffdc5..e500638 100644
On 2016/03/10 22:27, David Sterba wrote:
On Thu, Mar 10, 2016 at 08:04:59AM +0900, Satoru Takeuchi wrote:
It's unnecessary since it's always 1.
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to devel (commit b2bdd0da8969).
---
cmds-device.c | 3 +--
1 file
It's already marked as deprecated in cmd_device_scan_usage().
commit 5444864e5605 ("btrfs-progs: remove BTRFS_SCAN_PROC scan method")
Signed-off-by: Satoru Takeuchi
---
Documentation/btrfs-device.asciidoc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
It's unnecessary since it's always 1.
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to devel (commit b2bdd0da8969).
---
cmds-device.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmds-device.c b/cmds-device.c
index cb470af..78d6535 100644
On 2016/03/09 10:19, Yauhen Kharuzhy wrote:
> commit 52179e4fea41e55f31c92cd033a0b53a5107b4f4 'btrfs-progs: unify argc
> min/max checking' brokes 'btrfs device scan' command when no argument
> was given. Fix this.
>
> Signed-off-by: Yauhen Kharuzhy
> ---
> cmds-device.c | 2 +-
> 1 file change
cting such problem.
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to 4.5-rc7
V3:
- Show this message every time when hitting this problem
for simplicity (thanks to the comment from Goffredo).
- Reflect Naota's comment
- Keep the error code as is.
V2:
- Reflect Filipe
On 2016/03/09 11:32, Naohiro Aota wrote:
2016-03-07 12:05 GMT+09:00 Satoru Takeuchi :
- It's better to show a warning message for the exceptional case
that one of objectid (in most case, inode number) reaches its
highest value. Show this message only once to avoid filling
dmesg wi
On 2016/03/09 4:24, Goffredo Baroncelli wrote:
> On 2016-03-07 04:05, Satoru Takeuchi wrote:
>> - It's better to show a warning message for the exceptional case
>> that one of objectid (in most case, inode number) reaches its
>> highest value. Show this message
On 2016/03/09 2:04, David Sterba wrote:
> The document in the kernel sources is yet another palce where the
> documentation would need to be updated, while it is not the primary
> source. We actively maintain the wiki pages.
>
> Signed-off-by: David Sterba
> ---
> Documentation/filesystems/btrf
On 2016/03/08 17:46, Qu Wenruo wrote:
Satoru Takeuchi wrote on 2016/03/08 17:28 +0900:
Hi Qu,
On 2016/03/07 14:42, Qu Wenruo wrote:
Hi,
As many have already known, "btrfs check" is a memory eater.
The problem is, btrfsck checks extent tree in a very comprehensive
method.
Hi Qu,
On 2016/03/07 14:42, Qu Wenruo wrote:
Hi,
As many have already known, "btrfs check" is a memory eater.
The problem is, btrfsck checks extent tree in a very comprehensive method.
1) Create extent_ref for each extent item with backref
2) Iterate all other trees to add extent ref
3) If one
On 2016/03/07 12:05, Satoru Takeuchi wrote:
> - It's better to show a warning message for the exceptional case
>that one of objectid (in most case, inode number) reaches its
>highest value. Show this message only once to avoid filling
>dmesg with it.
> - EOVERFLOW i
ce left on device" case and objectid isn't
related to any device.
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to 4.5-rc7
---
fs/btrfs/inode-map.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c
in
Hi Filipe,
On 2016/03/04 18:28, Filipe Manana wrote:
On Fri, Mar 4, 2016 at 2:37 AM, Satoru Takeuchi
wrote:
- It's better to show a warning message for the exceptional case
that one of highest objectid (in most case, inode number)
reaches its max value, BTRFS_LAST_FREE_OBJECTID.
case.
ENOSPC is for "No space left on device" case and objectid isn't
related to any device.
Signed-off-by: Satoru Takeuchi
---
This patch can be applied to v4.5-rc6
---
fs/btrfs/inode-map.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/inode-ma
bsolute-names --dump $SCRATCH_MNT/testfile |
_filter_scratch
status=0
exit
Tested-by: Satoru Takeuchi
* chris/integration-4.6(HEAD is 790dd8b)
===
# ./check generic/337
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 fedora23 4.2.7-300.fc23
On 2016/02/18 0:11, David Sterba wrote:
On Wed, Feb 17, 2016 at 02:54:23PM +0900, Satoru Takeuchi wrote:
On 2016/02/16 2:53, David Sterba wrote:
On Mon, Feb 15, 2016 at 02:38:09PM +0900, Satoru Takeuchi wrote:
There are some BUG_ON()'s after kmalloc() as follows.
=
foo = km
On 2016/02/16 2:53, David Sterba wrote:
On Mon, Feb 15, 2016 at 02:38:09PM +0900, Satoru Takeuchi wrote:
There are some BUG_ON()'s after kmalloc() as follows.
=
foo = kmalloc();
BUG_ON(!foo); /* -ENOMEM case */
=
A Docker + memory cgroup user hit these BUG_ON()s.
ting these kmalloc() failures to avoid these
BUG_ON()s for now, are a bit better than the current
implementation anyway.
Signed-off-by: Satoru Takeuchi
---
fs/btrfs/extent_io.c | 6 ++
fs/btrfs/inode.c | 6 ++
fs/btrfs/relocation.c | 3 +--
3 files changed, 5 insertions(+), 10 deletion
Although BTRFS_ARG_BLKDEV can be returned from check_arg_type(),
it's not explained the meaning.
Signed-off-by: Satoru Takeuchi
---
utils.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/utils.c b/utils.c
index 3df8b42..eabc36d 100644
--- a/utils.c
+++ b/utils.c
@@ -1007,6 +1
Both man btrfs-send(8) and usage message don't describe
btrfs-send needs read-only snapshot as its argument.
Signed-off-by: Satoru Takeuchi
---
Documentation/btrfs-send.asciidoc | 1 +
cmds-send.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/
btrfs-subvolume(8) is mentioned at "SEE ALSO" section of itself.
Signed-off-by: Satoru Takeuchi
---
Documentation/btrfs-subvolume.asciidoc | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/btrfs-subvolume.asciidoc
b/Documentation/btrfs-subvolume.asciidoc
index c187fd
Hi Marcel,
On 2015/01/16 4:46, Marcel Ritter wrote:
Hi,
I just started some btrfs stress testing on latest linux kernel 3.19-rc4:
A few hours later, filesystem stopped working - the kernel bug report
can be found below.
The test consists of one massive IO thread (writing 100GB files with dd),
Hi,
On 2015/01/16 10:05, Tomasz Chmielewski wrote:
I just started some btrfs stress testing on latest linux kernel 3.19-rc4:
A few hours later, filesystem stopped working - the kernel bug report
can be found below.
Hi,
your "kernel BUG at fs/btrfs/inode.c:3142!" from 3.19-rc4 corresponds to
On 2015/01/07 18:23, Qu Wenruo wrote:
> Signed-off-by: Qu Wenruo
Reviewed-by: Satoru Takeuchi
> ---
> disk-io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/disk-io.c b/disk-io.c
> index 2bf8586..b853f66 100644
> --- a/disk-io.c
>
Hi Dongsheng,
On 2015/01/05 20:19, Dongsheng Yang wrote:
Ping.
IOCTL of BTRFS_IOC_SPACE_INFO currently does not report
the data used but not synced to user. Then btrfs fi df will
give user a wrong numbers before sync. This patch solve
this problem.
On 10/27/2014 08:38 PM, Dongsheng Yang
Hi Tomasz,
On 2014/12/20 8:28, Tomasz Chmielewski wrote:
Get this BUG with 3.18.1 (pasted at the bottom of the email).
Below all actions from creating the fs to BUG. I did not attempt to reproduce.
I tried to reproduce this problem and have some questions.
# mkfs.btrfs /dev/vdb
Btrfs v3.17.
even we
> free it normally.
>
> This patch move this WARN_ON() before freeing qg->excl.
>
> Signed-off-by: Dongsheng Yang
Reviewed-by: Satoru Takeuchi
> ---
> fs/btrfs/qgroup.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs
Hi Yang,
On 2015/01/05 15:16, Dongsheng Yang wrote:
> Hi Josef and others,
>
> This patch set is about enhancing qgroup.
>
> [1/3]: fix a bug about qgroup leak when we exceed quota limit,
> It is reviewd by Josef.
> [2/3]: introduce a new accounter in qgroup to close a window where
>
> next time.
>
> I reproduced ENOMEM case with the following script (need
> CONFIG_FAIL_PAGE_ALLOC, and CONFIG_FAULT_INJECTION_DEBUG_FS).
I confirmed that this problem reproduce with 3.19-rc3 and
not reproduce with 3.19-rc3 with your patch.
Tested-by: Satoru Takeuchi
Thank you for
th(), fix it.
>
> Signed-off-by: Qu Wenruo
Reviewed-by: Satoru Takeuchi
> ---
> cmds-check.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmds-check.c b/cmds-check.c
> index d2d218a..5b644cf 100644
> --- a/cmds-check.c
> +++ b/cmds-chec
Hi David,
On 2014/12/30 0:09, David Sterba wrote:
On Thu, Dec 25, 2014 at 06:21:41PM +0900, Satoru Takeuchi wrote:
From: Satoru Takeuchi
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2190,7 +2190,7 @@ void btrfs_free_io_failure_record(struct inode *inode,
u64 start, u64 end
1 - 100 of 269 matches
Mail list logo
