Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-10 Thread Sean Fu
On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: > On 9/8/16 11:08 PM, Sean Fu wrote: > > On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > >> On 9/6/16 5:58 AM, David Sterba wrote: > >>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Maho

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-08 Thread Sean Fu
On Thu, Sep 08, 2016 at 11:25:48PM -0400, Jeff Mahoney wrote: > On 9/8/16 11:08 PM, Sean Fu wrote: > > On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > >> On 9/6/16 5:58 AM, David Sterba wrote: > >>> On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Maho

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-08 Thread Sean Fu
On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > On 9/6/16 5:58 AM, David Sterba wrote: > > On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > Since root is only used to get fs_info->chunk_root, why not use fs_info > directly? > >>> > >>> Weird. Exactly this w

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Sean Fu
On Tue, Sep 06, 2016 at 11:12:20AM -0400, Jeff Mahoney wrote: > On 9/6/16 5:58 AM, David Sterba wrote: > > On Mon, Sep 05, 2016 at 11:13:40PM -0400, Jeff Mahoney wrote: > Since root is only used to get fs_info->chunk_root, why not use fs_info > directly? > >>> > >>> Weird. Exactly this w

Re: [PATCH v2] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Sean Fu
On Tue, Sep 06, 2016 at 01:19:39PM +0800, Zhao Lei wrote: > Hi, Sean Fu > > > -Original Message- > > From: Sean Fu [mailto:fxinr...@gmail.com] > > Sent: Tuesday, September 06, 2016 11:51 AM > > To: dste...@suse.com > > Cc: c...@fb.com; anand.j...@ora

Re: [PATCH] Btrfs: remove unnecessary code of chunk_root assignment in btrfs_read_chunk_tree.

2016-09-06 Thread Sean Fu
On Mon, Sep 05, 2016 at 03:56:41PM +0800, Qu Wenruo wrote: > > > At 09/05/2016 09:19 AM, Zhao Lei wrote: > >Hi, Sean Fu > > > >>From: Sean Fu [mailto:fxinr...@gmail.com] > >>Sent: Sunday, September 04, 2016 7:54 PM > >>To: dste...@suse.com &