Re: [PATCH 09/13] btrfs-progs: Revert "btrfs-progs: Record orphan data extent ref to corresponding root."

2018-11-07 Thread Su Yanjun
On 10/24/2018 8:29 AM, Qu Wenruo wrote: On 2018/10/23 下午5:41, Su Yue wrote: From: Su Yanjun The reason for revert is that according to the existing situation, the probability of problem in the extent tree is higher than in the fs Tree. So this feature should be removed. The same problem

Re: [PATCH 11/13] btrfs-progs: check: Delete file extent item with unaligned extent backref

2018-11-06 Thread Su Yanjun
On 11/7/2018 2:38 PM, Qu Wenruo wrote: On 2018/11/7 下午2:21, Su Yanjun wrote: On 10/24/2018 8:45 AM, Qu Wenruo wrote: On 2018/10/23 下午5:41, Su Yue wrote: From: Su Yanjun In original mode, if some file extent item has unaligned extent backref, fixup_extent_refs can't repair it.

Re: [PATCH 10/13] btrfs-progs: check: fix bug in find_possible_backrefs

2018-11-06 Thread Su Yanjun
On 10/24/2018 8:34 AM, Qu Wenruo wrote: On 2018/10/23 下午5:41, Su Yue wrote: From: Su Yanjun It may cost more time to search all extent data of correspond files but should not influence total speed too much cause that only corrupted extent items are participated in. Sorry, I didn't r

Re: [PATCH 11/13] btrfs-progs: check: Delete file extent item with unaligned extent backref

2018-11-06 Thread Su Yanjun
On 10/24/2018 8:45 AM, Qu Wenruo wrote: On 2018/10/23 下午5:41, Su Yue wrote: From: Su Yanjun In original mode, if some file extent item has unaligned extent backref, fixup_extent_refs can't repair it. This patch will check extent alignment then delete file extent with unaligned e

[PATCH] btrfs-progs: fix gcc8 default build warning caused by '-Wformat-truncation'

2018-10-25 Thread Su Yanjun
. Using the GCC option -Wno-format-truncation to disable this for default build. Signed-off-by: Su Yanjun --- Makefile.extrawarn | 1 + configure.ac | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.extrawarn b/Makefile.extrawarn index 1f4bda94a167..ed76fb5b5554 10

[PATCH] btrfs-progs: fix compile warning when using gcc8 to compile btrfs-progs

2018-10-12 Thread Su Yanjun
d-qualifiers] ret = btrfs_search_slot(NULL, root, key, p, 0, 0); Change btrfs_search_slot prototype with 'const' qualifier for argument 3. Also fix similar problems as above change. Signed-off-by: Su Yanjun --- ctree.c | 19 ++- ctree.h | 10 +- 2 files

[PATCH] btrfs-progs: fix compile warning when using gcc8 to compile btrfs-progs

2018-10-11 Thread Su Yanjun
. Using the GCC option -Wno-format-truncation to disable this. Signed-off-by: Su Yanjun --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index df02f20655d9..c626beca8b77 100644 --- a/configure.ac +++ b/configure.ac @@ -12,7 +12,7 @@

[PATCH] btrfs-progs: tests: Add the testcase for subvolume name length limit test

2018-09-18 Thread Su Yanjun
Total of three conditions are tested. One for short name, one with name length 255, the last one with more than 255. This case should pass after commit 'btrfs-progs: change filename limit to 255 when creating subvolume'. Signed-off-by: Su Yanjun --- .../033-filename-length-lim

[PATCH v2] btrfs-progs: change filename limit to 255 when creating subvolume

2018-09-17 Thread Su Yanjun
Modify the file name length limit to meet the Linux naming convention. In addition, the file name length is always bigger than 0, no need to compare with 0 again. Changelog: v2: Fix the same problem in creating snapshot routine. Issue: #145 Signed-off-by: Su Yanjun --- v2: Also fix the same

Re: [PATCH] btrfs-progs: change filename limit to 255 when creating subvolume

2018-09-16 Thread Su Yanjun
On 9/14/2018 10:34 PM, David Sterba wrote: On Wed, Sep 12, 2018 at 03:39:03PM +0800, Su Yanjun wrote: Modify the file name length limit to meet the Linux naming convention. In addition, the file name length is always bigger than 0, no need to compare with 0 again. Issue: #145 Signed-off-by

[PATCH] btrfs-progs: change filename limit to 255 when creating subvolume

2018-09-12 Thread Su Yanjun
Modify the file name length limit to meet the Linux naming convention. In addition, the file name length is always bigger than 0, no need to compare with 0 again. Issue: #145 Signed-off-by: Su Yanjun --- cmds-subvolume.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmds