Re: [Bug] check return of kmalloc()

2010-07-29 Thread Dan Carpenter
On Thu, Jul 29, 2010 at 11:15:57PM +0400, Vasiliy Kulikov wrote: > Hi, > > I've discovered that some btrfs code doesn't check whether kmalloc() > call succeeded. I poorly understand what this code does and how it can > be changed, maybe it would be happy with __GFP_NOFAIL. > > Also there are BU

[Bug] check return of kmalloc()

2010-07-29 Thread Vasiliy Kulikov
Hi, I've discovered that some btrfs code doesn't check whether kmalloc() call succeeded. I poorly understand what this code does and how it can be changed, maybe it would be happy with __GFP_NOFAIL. Also there are BUG_ON() after kmalloc()'s, if they could be changed not to panic it would be great