Re: [PATCH] [PATCH]Btrfs-prog: uniform error handling for utils.c

2014-10-28 Thread royy walls
You are correct, I tried to put all the error handling code in separate layer, but if there is no need to print error for each system call then it does not make sense to integrate this path. One of the userspace project on https://btrfs.wiki.kernel.org/index.php/Project_ideas#Userspace_tools_proje

Re: [PATCH] [PATCH]Btrfs-prog: uniform error handling for utils.c

2014-10-28 Thread David Sterba
Hi, without any explanation I can only speculate what's the purpose of this patch. I can see it hides the basic syscalls to wrappers and prints messages in case of an error value. Currently, the error codes are mostly handled and the error messages are printed as needed, we don't want to see all

Re: [PATCH] [PATCH]Btrfs-prog: uniform error handling for utils.c

2014-10-12 Thread royy walls
Hi, Following path implements the uniform error handling for the utils.c in btrfs-progs. On Sun, Oct 12, 2014 at 2:01 PM, neo wrote: > --- > Makefile | 4 +- > btrfs-syscalls.c | 180 + > btrfs-syscalls.h | 55 +++ > kerncom

[PATCH] [PATCH]Btrfs-prog: uniform error handling for utils.c

2014-10-12 Thread neo
--- Makefile | 4 +- btrfs-syscalls.c | 180 + btrfs-syscalls.h | 55 +++ kerncompat.h | 5 +- utils.c | 200 +++ 5 files changed, 337 insertions(+), 107 deleti