Re: [PATCH] Btrfs: add missing compression property remove in btrfs_ioctl_setflags

2014-09-15 Thread Satoru Takeuchi
Hi Filipe, # I added Chris to the CC list since this topic is to discuss # whether the current behavior is correct or not. (2014/09/11 18:48), Filipe David Manana wrote: On Thu, Sep 11, 2014 at 5:41 AM, Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com wrote: Hi Filipe, (2014/09/11 0:10),

Re: [PATCH] Btrfs: add missing compression property remove in btrfs_ioctl_setflags

2014-09-11 Thread Filipe David Manana
On Thu, Sep 11, 2014 at 5:41 AM, Satoru Takeuchi takeuchi_sat...@jp.fujitsu.com wrote: Hi Filipe, (2014/09/11 0:10), Filipe Manana wrote: The behaviour of a 'chattr -c' consists of getting the current flags, clearing the FS_COMPR_FL bit and then sending the result to the set flags ioctl -

[PATCH] Btrfs: add missing compression property remove in btrfs_ioctl_setflags

2014-09-10 Thread Filipe Manana
The behaviour of a 'chattr -c' consists of getting the current flags, clearing the FS_COMPR_FL bit and then sending the result to the set flags ioctl - this means the bit FS_NOCOMP_FL isn't set in the flags passed to the ioctl. This results in the compression property not being cleared from the

Re: [PATCH] Btrfs: add missing compression property remove in btrfs_ioctl_setflags

2014-09-10 Thread Satoru Takeuchi
Hi Filipe, (2014/09/11 0:10), Filipe Manana wrote: The behaviour of a 'chattr -c' consists of getting the current flags, clearing the FS_COMPR_FL bit and then sending the result to the set flags ioctl - this means the bit FS_NOCOMP_FL isn't set in the flags passed to the ioctl. This results