Re: [PATCH] Btrfs: allow empty subvol= again

2018-05-22 Thread David Sterba
> > This is silly but IMO it's a regression. If you agree, this should > > probably go to 4.17 + stable. I'll submit an xfstests test shortly. > > Update, we fixed the userspace bug now so I'd be fine if we dropped this > patch. I guess there's still a possibility that there are other users > that

Re: [PATCH] Btrfs: allow empty subvol= again

2018-05-21 Thread Omar Sandoval
On Mon, May 21, 2018 at 05:07:19PM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > I got a report that after upgrading to 4.16, someone's filesystems > weren't mounting: > > [ 23.845852] BTRFS info (device loop0): unrecognized mount option 'subvol=' > > Before 4.16, this mounted the def

[PATCH] Btrfs: allow empty subvol= again

2018-05-21 Thread Omar Sandoval
From: Omar Sandoval I got a report that after upgrading to 4.16, someone's filesystems weren't mounting: [ 23.845852] BTRFS info (device loop0): unrecognized mount option 'subvol=' Before 4.16, this mounted the default subvolume. It turns out that this empty "subvol=" is actually an applicati