Re: [PATCH] Btrfs: deal with unexpected return value in flush_space

2016-10-01 Thread Alex Lyakas
David, Holger, Thank you for picking up that old patch of mine. Alex. On Fri, Jul 29, 2016 at 8:53 PM, Liu Bo wrote: > On Fri, Jul 29, 2016 at 07:01:50PM +0200, David Sterba wrote: >> On Thu, Jul 28, 2016 at 11:49:14AM -0700, Liu Bo wrote: >> > > For reviewers - this came up before here: >> >

Re: [PATCH] Btrfs: deal with unexpected return value in flush_space

2016-07-29 Thread Liu Bo
On Fri, Jul 29, 2016 at 07:01:50PM +0200, David Sterba wrote: > On Thu, Jul 28, 2016 at 11:49:14AM -0700, Liu Bo wrote: > > > For reviewers - this came up before here: > > > https://patchwork.kernel.org/patch/7778651/ David, this patch made a mistake in commit log. > > > > > > Same fix basically

Re: [PATCH] Btrfs: deal with unexpected return value in flush_space

2016-07-29 Thread David Sterba
On Thu, Jul 28, 2016 at 11:49:14AM -0700, Liu Bo wrote: > > For reviewers - this came up before here: > > https://patchwork.kernel.org/patch/7778651/ > > > > Same fix basically. > > Aha, I've given it my Reviewed-by. > > Taking either one works for me, I can make the clarifying comment into a >

Re: [PATCH] Btrfs: deal with unexpected return value in flush_space

2016-07-28 Thread Liu Bo
On Thu, Jul 28, 2016 at 03:36:53PM +, Holger Hoffstätte wrote: > On Wed, 27 Jul 2016 18:42:03 -0700, Liu Bo wrote: > > > Function start_transaction() can return ERR_PTR(1) when flush is > > BTRFS_RESERVE_FLUSH_LIMIT, so the call graph is > > > > start_transaction (return ERR_PTR(1)) > > ->

Re: [PATCH] Btrfs: deal with unexpected return value in flush_space

2016-07-28 Thread Holger Hoffstätte
On Wed, 27 Jul 2016 18:42:03 -0700, Liu Bo wrote: > Function start_transaction() can return ERR_PTR(1) when flush is > BTRFS_RESERVE_FLUSH_LIMIT, so the call graph is > > start_transaction (return ERR_PTR(1)) > -> btrfs_block_rsv_add (return 1) > -> reserve_metadata_bytes (return 1) >

[PATCH] Btrfs: deal with unexpected return value in flush_space

2016-07-27 Thread Liu Bo
Function start_transaction() can return ERR_PTR(1) when flush is BTRFS_RESERVE_FLUSH_LIMIT, so the call graph is start_transaction (return ERR_PTR(1)) -> btrfs_block_rsv_add (return 1) -> reserve_metadata_bytes (return 1) -> flush_space (return 1) -> do_chunk_alloc (retu