Re: [PATCH] Btrfs: do not allow trimming when a fs is mounted with the nologreplay option

2019-03-28 Thread David Sterba
On Tue, Mar 26, 2019 at 02:39:45PM +0200, Nikolay Borisov wrote: > On 26.03.19 г. 14:35 ч., Filipe Manana wrote: > > On Tue, Mar 26, 2019 at 12:17 PM Nikolay Borisov wrote: > >> On 26.03.19 г. 12:49 ч., fdman...@kernel.org wrote: > >>> From: Filipe Manana > >>> > >>> Whan a filesystem is mounted

Re: [PATCH] Btrfs: do not allow trimming when a fs is mounted with the nologreplay option

2019-03-26 Thread David Sterba
On Tue, Mar 26, 2019 at 09:40:08PM +0800, Qu Wenruo wrote: > > > On 2019/3/26 下午8:17, Nikolay Borisov wrote: > > > > > > On 26.03.19 г. 12:49 ч., fdman...@kernel.org wrote: > >> From: Filipe Manana > >> > >> Whan a filesystem is mounted with the nologreplay mount option, which > >> requires it t

Re: [PATCH] Btrfs: do not allow trimming when a fs is mounted with the nologreplay option

2019-03-26 Thread Qu Wenruo
On 2019/3/26 下午8:17, Nikolay Borisov wrote: > > > On 26.03.19 г. 12:49 ч., fdman...@kernel.org wrote: >> From: Filipe Manana >> >> Whan a filesystem is mounted with the nologreplay mount option, which >> requires it to be mounted in RO mode as well, we can not allow discard on >> free space ins

Re: [PATCH] Btrfs: do not allow trimming when a fs is mounted with the nologreplay option

2019-03-26 Thread Nikolay Borisov
On 26.03.19 г. 14:35 ч., Filipe Manana wrote: > On Tue, Mar 26, 2019 at 12:17 PM Nikolay Borisov wrote: >> >> >> >> On 26.03.19 г. 12:49 ч., fdman...@kernel.org wrote: >>> From: Filipe Manana >>> >>> Whan a filesystem is mounted with the nologreplay mount option, which >>> requires it to be mo

Re: [PATCH] Btrfs: do not allow trimming when a fs is mounted with the nologreplay option

2019-03-26 Thread Filipe Manana
On Tue, Mar 26, 2019 at 12:17 PM Nikolay Borisov wrote: > > > > On 26.03.19 г. 12:49 ч., fdman...@kernel.org wrote: > > From: Filipe Manana > > > > Whan a filesystem is mounted with the nologreplay mount option, which > > requires it to be mounted in RO mode as well, we can not allow discard on >

Re: [PATCH] Btrfs: do not allow trimming when a fs is mounted with the nologreplay option

2019-03-26 Thread Nikolay Borisov
On 26.03.19 г. 12:49 ч., fdman...@kernel.org wrote: > From: Filipe Manana > > Whan a filesystem is mounted with the nologreplay mount option, which > requires it to be mounted in RO mode as well, we can not allow discard on > free space inside block groups, because log trees refer to extents t

[PATCH] Btrfs: do not allow trimming when a fs is mounted with the nologreplay option

2019-03-26 Thread fdmanana
From: Filipe Manana Whan a filesystem is mounted with the nologreplay mount option, which requires it to be mounted in RO mode as well, we can not allow discard on free space inside block groups, because log trees refer to extents that are not pinned in a block group's free space cache (pinning t