Re: [PATCH] Btrfs: do not change inode flags in rename

2013-02-26 Thread Josef Bacik
On Tue, Feb 26, 2013 at 05:33:00AM -0700, David Sterba wrote: > On Tue, Feb 26, 2013 at 08:11:17AM +0800, Liu Bo wrote: > > On Mon, Feb 25, 2013 at 01:56:47PM -0500, Josef Bacik wrote: > > > On Sun, Feb 24, 2013 at 09:04:42PM -0700, Liu Bo wrote: > > > > Before we forced to change a file's NOCOW an

Re: [PATCH] Btrfs: do not change inode flags in rename

2013-02-26 Thread David Sterba
On Tue, Feb 26, 2013 at 08:11:17AM +0800, Liu Bo wrote: > On Mon, Feb 25, 2013 at 01:56:47PM -0500, Josef Bacik wrote: > > On Sun, Feb 24, 2013 at 09:04:42PM -0700, Liu Bo wrote: > > > Before we forced to change a file's NOCOW and COMPRESS flag due to > > > the parent directory's, but this ends up

Re: [PATCH] Btrfs: do not change inode flags in rename

2013-02-25 Thread Liu Bo
On Mon, Feb 25, 2013 at 01:56:47PM -0500, Josef Bacik wrote: > On Sun, Feb 24, 2013 at 09:04:42PM -0700, Liu Bo wrote: > > Before we forced to change a file's NOCOW and COMPRESS flag due to > > the parent directory's, but this ends up a bad idea, because it > > confuses end users a lot about file's

Re: [PATCH] Btrfs: do not change inode flags in rename

2013-02-25 Thread Josef Bacik
On Sun, Feb 24, 2013 at 09:04:42PM -0700, Liu Bo wrote: > Before we forced to change a file's NOCOW and COMPRESS flag due to > the parent directory's, but this ends up a bad idea, because it > confuses end users a lot about file's NOCOW status, eg. if someone > change a file to NOCOW via 'chattr' a

Re: [PATCH] Btrfs: do not change inode flags in rename

2013-02-25 Thread Liu Bo
(add Miao to CC) On Mon, Feb 25, 2013 at 12:04:42PM +0800, Liu Bo wrote: > Before we forced to change a file's NOCOW and COMPRESS flag due to > the parent directory's, but this ends up a bad idea, because it > confuses end users a lot about file's NOCOW status, eg. if someone > change a file to NOC

Re: [PATCH] Btrfs: do not change inode flags in rename

2013-02-25 Thread David Sterba
On Mon, Feb 25, 2013 at 12:04:42PM +0800, Liu Bo wrote: > Before we forced to change a file's NOCOW and COMPRESS flag due to > the parent directory's, but this ends up a bad idea, because it > confuses end users a lot about file's NOCOW status, eg. if someone > change a file to NOCOW via 'chattr' a

[PATCH] Btrfs: do not change inode flags in rename

2013-02-24 Thread Liu Bo
Before we forced to change a file's NOCOW and COMPRESS flag due to the parent directory's, but this ends up a bad idea, because it confuses end users a lot about file's NOCOW status, eg. if someone change a file to NOCOW via 'chattr' and then rename it in the current directory which is without NOCO