Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2014-02-18 Thread Alex Lyakas
Hello Josef, On Tue, Dec 18, 2012 at 3:52 PM, Josef Bacik jba...@fusionio.com wrote: On Wed, Dec 12, 2012 at 06:52:37PM -0700, Liu Bo wrote: An user reported that he has hit an annoying deadlock while playing with ceph based on btrfs. Current updating device tree requires space from METADATA

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2014-02-18 Thread Josef Bacik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/18/2014 10:47 AM, Alex Lyakas wrote: Hello Josef, On Tue, Dec 18, 2012 at 3:52 PM, Josef Bacik jba...@fusionio.com wrote: On Wed, Dec 12, 2012 at 06:52:37PM -0700, Liu Bo wrote: An user reported that he has hit an annoying deadlock

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2014-02-18 Thread Alex Lyakas
Hi Josef, is this the commit to look at: 6df9a95e63395f595d0d1eb5d561dd6c91c40270 Btrfs: make the chunk allocator completely tree lockless or some other commits are also relevant? Alex. On Tue, Feb 18, 2014 at 6:06 PM, Josef Bacik jba...@fb.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash:

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2014-02-18 Thread Josef Bacik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/18/2014 11:24 AM, Alex Lyakas wrote: Hi Josef, is this the commit to look at: 6df9a95e63395f595d0d1eb5d561dd6c91c40270 Btrfs: make the chunk allocator completely tree lockless or some other commits are also relevant? It's been so long

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-31 Thread Josef Bacik
On Wed, Jan 30, 2013 at 02:37:40PM -0700, Jim Schutt wrote: On 01/30/2013 09:38 AM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote: On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-31 Thread Jim Schutt
On 01/31/2013 08:33 AM, Josef Bacik wrote: On Wed, Jan 30, 2013 at 02:37:40PM -0700, Jim Schutt wrote: On 01/30/2013 09:38 AM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote: On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700,

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-30 Thread Josef Bacik
On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote: On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef,

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-30 Thread Josef Bacik
On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote: On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef,

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-30 Thread Josef Bacik
On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote: On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef,

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-30 Thread Jim Schutt
On 01/30/2013 09:38 AM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote: On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-30 Thread Josef Bacik
On Wed, Jan 30, 2013 at 02:37:40PM -0700, Jim Schutt wrote: On 01/30/2013 09:38 AM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 04:05:17PM -0700, Jim Schutt wrote: On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread Josef Bacik
On Mon, Jan 28, 2013 at 07:30:09PM -0700, Liu Bo wrote: On Mon, Jan 28, 2013 at 04:23:31PM -0500, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing... Jim, I've been trying

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread Josef Bacik
On Tue, Jan 29, 2013 at 08:47:30AM -0500, Josef Bacik wrote: On Mon, Jan 28, 2013 at 07:30:09PM -0700, Liu Bo wrote: On Mon, Jan 28, 2013 at 04:23:31PM -0500, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread David Sterba
On Tue, Jan 29, 2013 at 08:50:34AM -0500, Josef Bacik wrote: On Tue, Jan 29, 2013 at 08:47:30AM -0500, Josef Bacik wrote: 251 [not run] FSTRIM is not supported Are you sure its 251? Thanks, Sorry it's early, I need a device that does trim. /me waits for his fusion card to get

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread David Sterba
On Tue, Jan 29, 2013 at 05:43:31PM +0100, David Sterba wrote: On Tue, Jan 29, 2013 at 08:50:34AM -0500, Josef Bacik wrote: You can use scsi_debug device with parm: lbpu:enable LBP, support UNMAP command (def=0) (int) Also, loop device with a file backed by a filesystem with hole

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread Jim Schutt
On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing... Jim, I've been trying to reason out how this happens, could you do a btrfs fi df on the filesystem thats giving

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread Josef Bacik
On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing... Jim, I've been trying to reason out how

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread Jim Schutt
On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing... Jim, I've

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-29 Thread Jim Schutt
On 01/29/2013 01:04 PM, Josef Bacik wrote: On Tue, Jan 29, 2013 at 11:41:10AM -0700, Jim Schutt wrote: On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing...

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-28 Thread Josef Bacik
On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing... Jim, I've been trying to reason out how this happens, could you do a btrfs fi df on the filesystem thats giving you trouble so I can see if what I think is

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-28 Thread Jim Schutt
On 01/28/2013 02:23 PM, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing... Jim, I've been trying to reason out how this happens, could you do a btrfs fi df on the filesystem thats giving

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-28 Thread Liu Bo
On Mon, Jan 28, 2013 at 04:23:31PM -0500, Josef Bacik wrote: On Thu, Jan 03, 2013 at 11:44:46AM -0700, Jim Schutt wrote: Hi Josef, Thanks for the patch - sorry for the long delay in testing... Jim, I've been trying to reason out how this happens, could you do a btrfs fi df on the

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2013-01-03 Thread Jim Schutt
Hi Josef, Thanks for the patch - sorry for the long delay in testing... On 12/18/2012 06:52 AM, Josef Bacik wrote: On Wed, Dec 12, 2012 at 06:52:37PM -0700, Liu Bo wrote: An user reported that he has hit an annoying deadlock while playing with ceph based on btrfs. Current updating device

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2012-12-18 Thread Josef Bacik
On Wed, Dec 12, 2012 at 06:52:37PM -0700, Liu Bo wrote: An user reported that he has hit an annoying deadlock while playing with ceph based on btrfs. Current updating device tree requires space from METADATA chunk, so we -may- need to do a recursive chunk allocation when adding/updating dev

Re: [PATCH] Btrfs: fix a deadlock on chunk mutex

2012-12-18 Thread Josef Bacik
On Tue, Dec 18, 2012 at 07:47:51AM -0700, Liu Bo wrote: On Tue, Dec 18, 2012 at 08:52:42AM -0500, Josef Bacik wrote: On Wed, Dec 12, 2012 at 06:52:37PM -0700, Liu Bo wrote: An user reported that he has hit an annoying deadlock while playing with ceph based on btrfs. Current

[PATCH] Btrfs: fix a deadlock on chunk mutex

2012-12-12 Thread Liu Bo
An user reported that he has hit an annoying deadlock while playing with ceph based on btrfs. Current updating device tree requires space from METADATA chunk, so we -may- need to do a recursive chunk allocation when adding/updating dev extent, that is where the deadlock comes from. If we use