Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-08-03 Thread robbieko
Filipe Manana 於 2018-08-02 01:55 寫到: On Wed, Aug 1, 2018 at 1:54 PM, Filipe Manana wrote: On Wed, Aug 1, 2018 at 11:20 AM, robbieko wrote: Filipe Manana 於 2018-07-31 19:33 寫到: On Tue, Jul 31, 2018 at 11:17 AM, robbieko wrote: Filipe Manana 於 2018-07-30 20:34 寫到: On Mon, Jul 30, 2018 at

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-08-01 Thread robbieko
Filipe Manana 於 2018-08-02 01:55 寫到: On Wed, Aug 1, 2018 at 1:54 PM, Filipe Manana wrote: On Wed, Aug 1, 2018 at 11:20 AM, robbieko wrote: Filipe Manana 於 2018-07-31 19:33 寫到: On Tue, Jul 31, 2018 at 11:17 AM, robbieko wrote: Filipe Manana 於 2018-07-30 20:34 寫到: On Mon, Jul 30, 2018 at

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-08-01 Thread Filipe Manana
On Wed, Aug 1, 2018 at 1:54 PM, Filipe Manana wrote: > On Wed, Aug 1, 2018 at 11:20 AM, robbieko wrote: >> Filipe Manana 於 2018-07-31 19:33 寫到: >> >>> On Tue, Jul 31, 2018 at 11:17 AM, robbieko wrote: Filipe Manana 於 2018-07-30 20:34 寫到: > On Mon, Jul 30, 2018 at 12:28 PM, Fil

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-08-01 Thread Filipe Manana
On Wed, Aug 1, 2018 at 11:20 AM, robbieko wrote: > Filipe Manana 於 2018-07-31 19:33 寫到: > >> On Tue, Jul 31, 2018 at 11:17 AM, robbieko wrote: >>> >>> Filipe Manana 於 2018-07-30 20:34 寫到: >>> On Mon, Jul 30, 2018 at 12:28 PM, Filipe Manana wrote: > > > On Mon, Jul 30, 2018

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-08-01 Thread robbieko
Filipe Manana 於 2018-07-31 19:33 寫到: On Tue, Jul 31, 2018 at 11:17 AM, robbieko wrote: Filipe Manana 於 2018-07-30 20:34 寫到: On Mon, Jul 30, 2018 at 12:28 PM, Filipe Manana wrote: On Mon, Jul 30, 2018 at 12:08 PM, Filipe Manana wrote: On Mon, Jul 30, 2018 at 11:21 AM, robbieko wrote:

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-07-31 Thread Filipe Manana
On Tue, Jul 31, 2018 at 11:17 AM, robbieko wrote: > Filipe Manana 於 2018-07-30 20:34 寫到: > >> On Mon, Jul 30, 2018 at 12:28 PM, Filipe Manana >> wrote: >>> >>> On Mon, Jul 30, 2018 at 12:08 PM, Filipe Manana >>> wrote: On Mon, Jul 30, 2018 at 11:21 AM, robbieko wrote: > >

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-07-31 Thread robbieko
Filipe Manana 於 2018-07-30 20:34 寫到: On Mon, Jul 30, 2018 at 12:28 PM, Filipe Manana wrote: On Mon, Jul 30, 2018 at 12:08 PM, Filipe Manana wrote: On Mon, Jul 30, 2018 at 11:21 AM, robbieko wrote: From: Robbie Ko Commit e9894fd3e3b3 ("Btrfs: fix snapshot vs nocow writting") modified the n

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-07-30 Thread Filipe Manana
On Mon, Jul 30, 2018 at 12:28 PM, Filipe Manana wrote: > On Mon, Jul 30, 2018 at 12:08 PM, Filipe Manana wrote: >> On Mon, Jul 30, 2018 at 11:21 AM, robbieko wrote: >>> From: Robbie Ko >>> >>> Commit e9894fd3e3b3 ("Btrfs: fix snapshot vs nocow writting") >>> modified the nocow writeback mechani

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-07-30 Thread Filipe Manana
On Mon, Jul 30, 2018 at 12:08 PM, Filipe Manana wrote: > On Mon, Jul 30, 2018 at 11:21 AM, robbieko wrote: >> From: Robbie Ko >> >> Commit e9894fd3e3b3 ("Btrfs: fix snapshot vs nocow writting") >> modified the nocow writeback mechanism, if you create a snapshot, >> it will always switch to cow w

Re: [PATCH] Btrfs: fix data lose with snapshot when nospace

2018-07-30 Thread Filipe Manana
On Mon, Jul 30, 2018 at 11:21 AM, robbieko wrote: > From: Robbie Ko > > Commit e9894fd3e3b3 ("Btrfs: fix snapshot vs nocow writting") > modified the nocow writeback mechanism, if you create a snapshot, > it will always switch to cow writeback. > > This will cause data loss when there is no space,

[PATCH] Btrfs: fix data lose with snapshot when nospace

2018-07-30 Thread robbieko
From: Robbie Ko Commit e9894fd3e3b3 ("Btrfs: fix snapshot vs nocow writting") modified the nocow writeback mechanism, if you create a snapshot, it will always switch to cow writeback. This will cause data loss when there is no space, because when the space is full, the write will not reserve any