Hi, David,
On 2013/12/17 0:27, David Sterba wrote:
On Fri, Dec 13, 2013 at 09:51:42AM +0900, Tsutomu Itoh wrote:
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -4974,10 +4974,17 @@ static void btrfs_dentry_release(struct dentry *dentry)
static struct dentry *btrfs_lookup(struct inode *dir,
On Fri, Dec 13, 2013 at 09:51:42AM +0900, Tsutomu Itoh wrote:
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -4974,10 +4974,17 @@ static void btrfs_dentry_release(struct dentry
> *dentry)
> static struct dentry *btrfs_lookup(struct inode *dir, struct dentry *dentry,
>
Clean up btrfs_lookup_dentry() to never return NULL, but PTR_ERR(-ENOENT)
instead. This keeps the return value convention consistent.
Callers who use btrfs_lookup_dentry() require a trivial update.
create_snapshot() in particular looks like it can also lose a BUG_ON(!inode)
which is not really ne
(2011/06/28 23:22), Josef Bacik wrote:
> On 06/27/2011 11:34 PM, Tsutomu Itoh wrote:
>> The return value of btrfs_lookup_dentry is checked so that
>> the panic such as illegal address reference should not occur.
>>
>> Signed-off-by: Tsutomu Itoh
>
> Nack, please fix btrfs_lookup_dentry to return
On 06/27/2011 11:34 PM, Tsutomu Itoh wrote:
> The return value of btrfs_lookup_dentry is checked so that
> the panic such as illegal address reference should not occur.
>
> Signed-off-by: Tsutomu Itoh
Nack, please fix btrfs_lookup_dentry to return ERR_PTR(-ENOENT) if it
doesn't find something.
The return value of btrfs_lookup_dentry is checked so that
the panic such as illegal address reference should not occur.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/inode.c |1 +
fs/btrfs/ioctl.c | 10 +-
2 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/inode.c
