Re: [PATCH] Btrfs: fix missing mutex_unlock in btrfs_del_dir_entries_in_log()

2011-04-24 Thread Tsutomu Itoh
(2011/04/22 21:45), David Sterba wrote: > Hi, > > On Fri, Apr 22, 2011 at 06:05:40PM +0900, Tsutomu Itoh wrote: >> It is necessary to unlock mutex_lock before it return an error when >> btrfs_alloc_path() fails. > > good catch! however I suggest to move the mutex_lock after the > allocation and c

Re: [PATCH] Btrfs: fix missing mutex_unlock in btrfs_del_dir_entries_in_log()

2011-04-22 Thread David Sterba
Hi, On Fri, Apr 22, 2011 at 06:05:40PM +0900, Tsutomu Itoh wrote: > It is necessary to unlock mutex_lock before it return an error when > btrfs_alloc_path() fails. good catch! however I suggest to move the mutex_lock after the allocation and check, it'll be semantically equivalent to your change,

[PATCH] Btrfs: fix missing mutex_unlock in btrfs_del_dir_entries_in_log()

2011-04-22 Thread Tsutomu Itoh
It is necessary to unlock mutex_lock before it return an error when btrfs_alloc_path() fails. Signed-off-by: Tsutomu Itoh --- fs/btrfs/tree-log.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index c50271a..f997ec0 100644