Re: [PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-07-02 Thread Jan Schmidt
On Sun, June 30, 2013 at 15:55 (+0200), Josef Bacik wrote: > On Sun, Jun 30, 2013 at 10:25:05AM +0200, Jan Schmidt wrote: >> On 30.06.2013 05:17, Josef Bacik wrote: >>> We need to hold the tree mod log lock in __tree_mod_log_rewind since we walk >>> forward in the tree mod entries, otherwise we'll

Re: [PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-07-01 Thread Liu Bo
On Sun, Jun 30, 2013 at 02:01:17PM -0400, Josef Bacik wrote: > On Sun, Jun 30, 2013 at 11:02:10PM +0800, Liu Bo wrote: > > On Sun, Jun 30, 2013 at 07:22:00AM -0400, Josef Bacik wrote: > > > On Sun, Jun 30, 2013 at 10:25:05AM +0200, Jan Schmidt wrote: > > > > On 30.06.2013 05:17, Josef Bacik wrote:

Re: [PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-06-30 Thread Josef Bacik
On Sun, Jun 30, 2013 at 11:02:10PM +0800, Liu Bo wrote: > On Sun, Jun 30, 2013 at 07:22:00AM -0400, Josef Bacik wrote: > > On Sun, Jun 30, 2013 at 10:25:05AM +0200, Jan Schmidt wrote: > > > On 30.06.2013 05:17, Josef Bacik wrote: > > > > We need to hold the tree mod log lock in __tree_mod_log_rewin

Re: [PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-06-30 Thread Liu Bo
On Sun, Jun 30, 2013 at 07:22:00AM -0400, Josef Bacik wrote: > On Sun, Jun 30, 2013 at 10:25:05AM +0200, Jan Schmidt wrote: > > On 30.06.2013 05:17, Josef Bacik wrote: > > > We need to hold the tree mod log lock in __tree_mod_log_rewind since we > > > walk > > > forward in the tree mod entries, ot

Re: [PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-06-30 Thread Josef Bacik
On Sun, Jun 30, 2013 at 10:25:05AM +0200, Jan Schmidt wrote: > On 30.06.2013 05:17, Josef Bacik wrote: > > We need to hold the tree mod log lock in __tree_mod_log_rewind since we walk > > forward in the tree mod entries, otherwise we'll end up with random entries > > and > > trip the BUG_ON() at t

Re: [PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-06-30 Thread Josef Bacik
On Sun, Jun 30, 2013 at 10:25:05AM +0200, Jan Schmidt wrote: > On 30.06.2013 05:17, Josef Bacik wrote: > > We need to hold the tree mod log lock in __tree_mod_log_rewind since we walk > > forward in the tree mod entries, otherwise we'll end up with random entries > > and > > trip the BUG_ON() at t

Re: [PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-06-30 Thread Jan Schmidt
On 30.06.2013 05:17, Josef Bacik wrote: > We need to hold the tree mod log lock in __tree_mod_log_rewind since we walk > forward in the tree mod entries, otherwise we'll end up with random entries > and > trip the BUG_ON() at the front of __tree_mod_log_rewind. This fixes the > panics > people w

[PATCH] Btrfs: hold the tree mod lock in __tree_mod_log_rewind

2013-06-29 Thread Josef Bacik
We need to hold the tree mod log lock in __tree_mod_log_rewind since we walk forward in the tree mod entries, otherwise we'll end up with random entries and trip the BUG_ON() at the front of __tree_mod_log_rewind. This fixes the panics people were seeing when running find /whatever -type f -exec