Re: [PATCH] Btrfs: optimize to remove unnecessary removal with ulist reallocation

2014-01-24 Thread Wang Shilong
Hi Liu, On 01/13/2014 10:31 AM, Liu Bo wrote: On Fri, Jan 10, 2014 at 09:25:46PM +0800, Wang Shilong wrote: Here we are not going to free memory, no need to remove every node one by one, just init root node here is ok. Looks fine, but we need to make sure that it passes the regression test sin

Re: [PATCH] Btrfs: optimize to remove unnecessary removal with ulist reallocation

2014-01-12 Thread Liu Bo
On Fri, Jan 10, 2014 at 09:25:46PM +0800, Wang Shilong wrote: > Here we are not going to free memory, no need to remove every node > one by one, just init root node here is ok. Looks fine, but we need to make sure that it passes the regression test since you're working on an old bug. -liubo >

[PATCH] Btrfs: optimize to remove unnecessary removal with ulist reallocation

2014-01-10 Thread Wang Shilong
Here we are not going to free memory, no need to remove every node one by one, just init root node here is ok. Cc: Liu Bo Signed-off-by: Wang Shilong --- fs/btrfs/ulist.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/btrfs/ulist.c b/fs/btrfs/ulist.c index b0a523b2..