Re: [PATCH] Btrfs: race free update of super flags

2013-08-05 Thread Zach Brown
On Sat, Aug 03, 2013 at 07:43:17PM +0100, Filipe David Borba Manana wrote: Before updating the super block's flags, which is a non-atomic operation, grab the super_lock in the fs_info structure. At the moment only 2 different code paths can update these flags in parallel: Hmm. You say the

Re: [PATCH] Btrfs: race free update of super flags

2013-08-05 Thread Filipe David Manana
On Mon, Aug 5, 2013 at 11:10 PM, Zach Brown z...@redhat.com wrote: On Sat, Aug 03, 2013 at 07:43:17PM +0100, Filipe David Borba Manana wrote: Before updating the super block's flags, which is a non-atomic operation, grab the super_lock in the fs_info structure. At the moment only 2 different

Re: [PATCH] Btrfs: race free update of super flags

2013-08-05 Thread Zach Brown
I guess got confused, must have thought both referred to root-fs_info-super_copy. No worries. I honestly wasn't sure if I was just missing something :) - z (you are in a maze of twisty little super blocks, all alike) -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in

[PATCH] Btrfs: race free update of super flags

2013-08-03 Thread Filipe David Borba Manana
Before updating the super block's flags, which is a non-atomic operation, grab the super_lock in the fs_info structure. At the moment only 2 different code paths can update these flags in parallel: 1) when adding a new device 2) writing all super block copies to disk Signed-off-by: Filipe David