Re: [PATCH] Btrfs: remove duplicated btrfs_release_path in btrfs_unlink_subvol

2018-08-15 Thread Liu Bo
On Wed, Aug 15, 2018 at 4:48 AM, David Sterba wrote: > On Wed, Aug 15, 2018 at 10:52:56AM +0800, Liu Bo wrote: >> On Tue, Aug 14, 2018 at 12:46:00PM +0200, David Sterba wrote: >> > On Tue, Aug 14, 2018 at 10:47:09AM +0800, Liu Bo wrote: >> > > The btrfs_release_path() is just useless as path is

Re: [PATCH] Btrfs: remove duplicated btrfs_release_path in btrfs_unlink_subvol

2018-08-15 Thread David Sterba
On Wed, Aug 15, 2018 at 10:52:56AM +0800, Liu Bo wrote: > On Tue, Aug 14, 2018 at 12:46:00PM +0200, David Sterba wrote: > > On Tue, Aug 14, 2018 at 10:47:09AM +0800, Liu Bo wrote: > > > The btrfs_release_path() is just useless as path is only used in error > > > handling. > > > > Where is it

Re: [PATCH] Btrfs: remove duplicated btrfs_release_path in btrfs_unlink_subvol

2018-08-14 Thread Liu Bo
On Tue, Aug 14, 2018 at 12:46:00PM +0200, David Sterba wrote: > On Tue, Aug 14, 2018 at 10:47:09AM +0800, Liu Bo wrote: > > The btrfs_release_path() is just useless as path is only used in error > > handling. > > Where is it duplicated? And I don't think it's useless, while the > changelog does

Re: [PATCH] Btrfs: remove duplicated btrfs_release_path in btrfs_unlink_subvol

2018-08-14 Thread David Sterba
On Tue, Aug 14, 2018 at 10:47:09AM +0800, Liu Bo wrote: > The btrfs_release_path() is just useless as path is only used in error > handling. Where is it duplicated? And I don't think it's useless, while the changelog does not explain why and it's not obvious from the context. If the path is

[PATCH] Btrfs: remove duplicated btrfs_release_path in btrfs_unlink_subvol

2018-08-13 Thread Liu Bo
The btrfs_release_path() is just useless as path is only used in error handling. Signed-off-by: Liu Bo --- fs/btrfs/inode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index eba61bcb9bb3..5680e9c462a3 100644 --- a/fs/btrfs/inode.c +++