Re: [PATCH] Btrfs: remove duplicated find_get_pages_contig

2017-02-02 Thread David Sterba
On Thu, Feb 02, 2017 at 11:11:15AM -0800, Liu Bo wrote: > On Thu, Feb 02, 2017 at 07:42:43PM +0100, David Sterba wrote: > > On Mon, Jan 30, 2017 at 12:26:30PM -0800, Liu Bo wrote: > > > This creates a helper to manipulate page bits to avoid duplicate uses. > > > > This seems too short for what

Re: [PATCH] Btrfs: remove duplicated find_get_pages_contig

2017-02-02 Thread Liu Bo
On Thu, Feb 02, 2017 at 07:42:43PM +0100, David Sterba wrote: > On Mon, Jan 30, 2017 at 12:26:30PM -0800, Liu Bo wrote: > > This creates a helper to manipulate page bits to avoid duplicate uses. > > This seems too short for what the patch does. It adds a new page ops bit > that would deserve a

Re: [PATCH] Btrfs: remove duplicated find_get_pages_contig

2017-02-02 Thread David Sterba
On Mon, Jan 30, 2017 at 12:26:30PM -0800, Liu Bo wrote: > This creates a helper to manipulate page bits to avoid duplicate uses. This seems too short for what the patch does. It adds a new page ops bit that would deserve a separate patch. Please try to split it to smaller parts. > +static

[PATCH] Btrfs: remove duplicated find_get_pages_contig

2017-01-30 Thread Liu Bo
This creates a helper to manipulate page bits to avoid duplicate uses. Signed-off-by: Liu Bo --- fs/btrfs/extent_io.c | 202 --- fs/btrfs/extent_io.h | 3 +- 2 files changed, 98 insertions(+), 107 deletions(-) diff --git