Re: [PATCH] Btrfs: tolerate errors if we have retried successfully

2017-05-15 Thread David Sterba
On Tue, May 09, 2017 at 12:40:53PM -0700, Liu Bo wrote: > On Fri, May 05, 2017 at 06:52:45PM +0200, David Sterba wrote: > > On Thu, Apr 13, 2017 at 06:11:56PM -0700, Liu Bo wrote: > > > With raid1 profile, dio read isn't tolerating IO errors if read length is > > > less than the stripe length (64K)

Re: [PATCH] Btrfs: tolerate errors if we have retried successfully

2017-05-09 Thread Liu Bo
On Fri, May 05, 2017 at 06:52:45PM +0200, David Sterba wrote: > On Thu, Apr 13, 2017 at 06:11:56PM -0700, Liu Bo wrote: > > With raid1 profile, dio read isn't tolerating IO errors if read length is > > less than the stripe length (64K). > > Can you please write more details why this is true? Some

Re: [PATCH] Btrfs: tolerate errors if we have retried successfully

2017-05-05 Thread David Sterba
On Thu, Apr 13, 2017 at 06:11:56PM -0700, Liu Bo wrote: > With raid1 profile, dio read isn't tolerating IO errors if read length is > less than the stripe length (64K). Can you please write more details why this is true? Some pointers to code etc, I'm lost. Eg. where the errors is tolerated. Thank

[PATCH] Btrfs: tolerate errors if we have retried successfully

2017-04-13 Thread Liu Bo
With raid1 profile, dio read isn't tolerating IO errors if read length is less than the stripe length (64K). This fixes the problem by setting bio's error to 0 if a good copy has been found. Signed-off-by: Liu Bo --- fs/btrfs/inode.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) di