Re: [PATCH] Btrfs: use WARN_ON_ONCE instead for btrfs_invalidate_inodes

2014-01-04 Thread Josef Bacik
On 12/30/2013 02:51 AM, Liu Bo wrote: So after transaction is aborted, we need to cleanup inode resources by calling btrfs_invalidate_inodes(), and btrfs_invalidate_inodes() hopes roots' refs to be zero in old times and sets a WARN_ON(), however, this is not always true within cleaning up

[PATCH] Btrfs: use WARN_ON_ONCE instead for btrfs_invalidate_inodes

2013-12-29 Thread Liu Bo
So after transaction is aborted, we need to cleanup inode resources by calling btrfs_invalidate_inodes(), and btrfs_invalidate_inodes() hopes roots' refs to be zero in old times and sets a WARN_ON(), however, this is not always true within cleaning up transaction, so WARN_ON_ONCE() is better, and