Re: [PATCH] Btrfs: use self-explaining variable

2017-09-24 Thread David Sterba
On Sat, Sep 23, 2017 at 09:09:24AM +0800, Qu Wenruo wrote: > > > On 2017年09月23日 08:48, Liu Bo wrote: > > On Sat, Sep 23, 2017 at 08:46:55AM +0800, Qu Wenruo wrote: > >> > >> > >> On 2017年09月23日 07:36, Liu Bo wrote: > >>> This uses a bool 'do_backup' to help understand this piece of code. > >>> >

Re: [PATCH] Btrfs: use self-explaining variable

2017-09-22 Thread Qu Wenruo
On 2017年09月23日 08:48, Liu Bo wrote: On Sat, Sep 23, 2017 at 08:46:55AM +0800, Qu Wenruo wrote: On 2017年09月23日 07:36, Liu Bo wrote: This uses a bool 'do_backup' to help understand this piece of code. Signed-off-by: Liu Bo --- This is based on a patch "Btrfs: do not backup tree roots when f

Re: [PATCH] Btrfs: use self-explaining variable

2017-09-22 Thread Liu Bo
On Sat, Sep 23, 2017 at 08:46:55AM +0800, Qu Wenruo wrote: > > > On 2017年09月23日 07:36, Liu Bo wrote: > > This uses a bool 'do_backup' to help understand this piece of code. > > > > Signed-off-by: Liu Bo > > --- > > This is based on a patch "Btrfs: do not backup tree roots when fsync". > > > >

Re: [PATCH] Btrfs: use self-explaining variable

2017-09-22 Thread Qu Wenruo
On 2017年09月23日 07:36, Liu Bo wrote: This uses a bool 'do_backup' to help understand this piece of code. Signed-off-by: Liu Bo --- This is based on a patch "Btrfs: do not backup tree roots when fsync". fs/btrfs/disk-io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH] Btrfs: use self-explaining variable

2017-09-22 Thread Liu Bo
This uses a bool 'do_backup' to help understand this piece of code. Signed-off-by: Liu Bo --- This is based on a patch "Btrfs: do not backup tree roots when fsync". fs/btrfs/disk-io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c i