On Mon, May 27, 2013 at 01:31:13PM +0100, Filipe David Manana wrote:
> Right. Just thought it was better to check if the calloc() for fs_info
> succeeded before derreferencing it for free'ing its super_copy member
> (the function's code doesn't check if any of the malloc() / calloc()
> calls return
On Mon, May 27, 2013 at 1:12 PM, David Sterba wrote:
> Hi,
>
> please don't forget to mention what changed in a revised version
Yeah, sorry, it was my first usage of git send-email (as described in the wiki).
>
> On Sat, May 25, 2013 at 03:16:39PM +0100, Filipe David Borba Manana wrote:
>> @@ -2
Hi,
please don't forget to mention what changed in a revised version
On Sat, May 25, 2013 at 03:16:39PM +0100, Filipe David Borba Manana wrote:
> @@ -228,6 +227,8 @@ out:
> free(chunk_root);
> free(dev_root);
> free(csum_root);
> + if (fs_info)
> + free(fs_info->
There was a missing free() call against fs_info->super_copy
in several places:
1) close_ctree()
2) open_ctree_broken() on failure
3) __open_ctree_fd() on failure
Signed-off-by: Filipe David Borba Manana
---
btrfs-find-root.c |5 +++--
disk-io.c |6 --
2 files changed, 7 in
There was a missing free() call against fs_info->super_copy
in several places:
1) close_ctree()
2) open_ctree_broken() on failure
3) __open_ctree_fd() on failure
Filipe David Borba Manana (1):
Btrfs-progs: Add missing free() against fs_info->super_copy
btrfs-find-root.c |5 +++--
disk-i
There was a missing free() call against fs_info->super_copy
in several places:
1) close_ctree()
2) open_ctree_broken() on failure
3) __open_ctree_fd() on failure
Signed-off-by: Filipe David Borba Manana
---
btrfs-find-root.c |4 ++--
disk-io.c |5 +++--
2 files changed, 5 inse
There was a missing free() call against fs_info->super_copy
in several places:
1) close_ctree()
2) open_ctree_broken() on failure
3) __open_ctree_fd() on failure
Filipe David Borba Manana (1):
Btrfs-progs: Add missing free() against fs_info->super_copy
btrfs-find-root.c |4 ++--
disk-io
