Re: [PATCH] Btrfs-progs: convert: do not clear header rev

2017-06-30 Thread Lu Fengqi
On Fri, Jun 30, 2017 at 04:52:54PM +0200, David Sterba wrote: >On Tue, Jun 27, 2017 at 12:07:13PM -0700, Liu Bo wrote: >> On Mon, Jun 26, 2017 at 05:55:02PM -0600, Liu Bo wrote: >> > So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is >> > sort of >> > similar to "=" vs "|=",

Re: [PATCH] Btrfs-progs: convert: do not clear header rev

2017-06-30 Thread David Sterba
On Tue, Jun 27, 2017 at 12:07:13PM -0700, Liu Bo wrote: > On Mon, Jun 26, 2017 at 05:55:02PM -0600, Liu Bo wrote: > > So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is > > sort of > > similar to "=" vs "|=", when creating and initialising a new extent buffer, > > convert

Re: [PATCH] Btrfs-progs: convert: do not clear header rev

2017-06-27 Thread Liu Bo
On Mon, Jun 26, 2017 at 05:55:02PM -0600, Liu Bo wrote: > So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is sort > of > similar to "=" vs "|=", when creating and initialising a new extent buffer, > convert uses the former one which clears header_rev by accident. > Here is

Re: [PATCH] Btrfs-progs: convert: do not clear header rev

2017-06-26 Thread Qu Wenruo
At 06/27/2017 07:55 AM, Liu Bo wrote: So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is sort of similar to "=" vs "|=", when creating and initialising a new extent buffer, convert uses the former one which clears header_rev by accident. Thanks for catching this one.

[PATCH] Btrfs-progs: convert: do not clear header rev

2017-06-26 Thread Liu Bo
So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is sort of similar to "=" vs "|=", when creating and initialising a new extent buffer, convert uses the former one which clears header_rev by accident. Signed-off-by: Liu Bo --- convert/common.c | 2 +- 1