Re: [PATCH] Btrfs-progs: fail gracefully on error from open_ctree()

2011-12-12 Thread Ilya Dryomov
On Mon, Dec 12, 2011 at 03:40:19PM +0100, David Sterba wrote: > On Tue, Nov 01, 2011 at 11:47:22PM +0200, Ilya Dryomov wrote: > > --- a/mkfs.c > > +++ b/mkfs.c > > @@ -1328,7 +1328,12 @@ int main(int ac, char **av) > > fprintf(stderr, "error during mkfs %d\n", ret); > > exit

Re: [PATCH] Btrfs-progs: fail gracefully on error from open_ctree()

2011-12-12 Thread David Sterba
On Tue, Nov 01, 2011 at 11:47:22PM +0200, Ilya Dryomov wrote: > --- a/mkfs.c > +++ b/mkfs.c > @@ -1328,7 +1328,12 @@ int main(int ac, char **av) > fprintf(stderr, "error during mkfs %d\n", ret); > exit(1); > } > + > root = open_ctree(file, 0, O_RDWR); > +

[PATCH] Btrfs-progs: fail gracefully on error from open_ctree()

2011-11-01 Thread Ilya Dryomov
Error checking block got moved mistakenly exposing us to a potential segmentation fault. Signed-off-by: Ilya Dryomov --- mkfs.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/mkfs.c b/mkfs.c index e3ced19..a6f6b1f 100644 --- a/mkfs.c +++ b/mkfs.c @@ -1328,7 +132