Re: [PATCH] Fix undefined behavior in radix-tree.c.

2014-06-19 Thread Satoru Takeuchi
Hi David, (2014/06/19 22:28), David Sterba wrote: On Thu, Jun 19, 2014 at 10:10:55AM +0900, Satoru Takeuchi wrote: It's fixed at 430d275a399. === commit 430d275a399175c7c0673459738979287ec1fd22 Author: Peter Lund Date

Re: [PATCH] Fix undefined behavior in radix-tree.c.

2014-06-19 Thread David Sterba
On Thu, Jun 19, 2014 at 10:10:55AM +0900, Satoru Takeuchi wrote: > It's fixed at 430d275a399. > > === > commit 430d275a399175c7c0673459738979287ec1fd22 > Author: Peter Lund > Date: Tue Oct 16 23:29:35 2007 -0700 > >

Re: [PATCH] Fix undefined behavior in radix-tree.c.

2014-06-18 Thread Satoru Takeuchi
Hi David, Adam, (2014/06/18 23:43), David Sterba wrote: On Wed, Jun 18, 2014 at 03:20:30PM +0900, Satoru Takeuchi wrote: Hi Adam, (2014/06/14 6:18), Adam Buchbinder wrote: When running with UndefinedBehaviorSanitizer, the tests produce the following error: radix-tree.c:836:30: runtime er

Re: [PATCH] Fix undefined behavior in radix-tree.c.

2014-06-18 Thread David Sterba
On Wed, Jun 18, 2014 at 03:20:30PM +0900, Satoru Takeuchi wrote: > Hi Adam, > > (2014/06/14 6:18), Adam Buchbinder wrote: > > When running with UndefinedBehaviorSanitizer, the tests produce the > > following > > error: > > > >radix-tree.c:836:30: runtime error: shift exponent 184467440737095

Re: [PATCH] Fix undefined behavior in radix-tree.c.

2014-06-17 Thread Satoru Takeuchi
Hi Adam, (2014/06/14 6:18), Adam Buchbinder wrote: > When running with UndefinedBehaviorSanitizer, the tests produce the following > error: > >radix-tree.c:836:30: runtime error: shift exponent 18446744073709551613 >is too large for 64-bit type 'unsigned long' > > (That's a negative shif

[PATCH] Fix undefined behavior in radix-tree.c.

2014-06-13 Thread Adam Buchbinder
When running with UndefinedBehaviorSanitizer, the tests produce the following error: radix-tree.c:836:30: runtime error: shift exponent 18446744073709551613 is too large for 64-bit type 'unsigned long' (That's a negative shift exponent represented as an unsigned long.) Even though the value