l.org
Subject: Re: [PATCH] Tidy while loop in end_compressed_writeback
On Wed, Apr 19, 2017 at 05:43:19AM -0700, Sahil Kang wrote:
> This is my first patch so it's a minor code change.
> I think removing the early continue from the loop makes the function a
> little easier to f
On Wed, Apr 19, 2017 at 05:43:19AM -0700, Sahil Kang wrote:
> This is my first patch so it's a minor code change.
> I think removing the early continue from the loop makes the function a
> little easier to follow.
I think the opposite. In the current code, it's clear that if ret is 0,
then there'
ction a
little easier to follow.
Please have a look and I'd appreciate any feedback.
Thanks,
Sahil
From 98afe83a570180e841fefe3fd48d450accc42ea3 Mon Sep 17 00:00:00 2001
From: Sahil Kang
Date: Wed, 19 Apr 2017 04:47:00 -0700
Subject: [PATCH] Tidy while loop in end_compressed_writeback
Instead
the early continue from the loop makes the function a
little easier to follow.
Please have a look and I'd appreciate any feedback.
Thanks,
Sahil
From 98afe83a570180e841fefe3fd48d450accc42ea3 Mon Sep 17 00:00:00 2001
From: Sahil Kang
Date: Wed, 19 Apr 2017 04:47:00 -0700
Subject: [PATCH] Tid
00:00 2001
From: Sahil Kang
Date: Wed, 19 Apr 2017 04:47:00 -0700
Subject: [PATCH] Tidy while loop in end_compressed_writeback
Instead of continuing early in the loop when ret is 0,
we can decrement/increment nr_pages/index by 1 at the ending.
The for loop will not execute when ret is 0 anyway.
Sig
