Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings

2019-06-03 Thread David Sterba
On Fri, May 31, 2019 at 10:53:49PM +0300, Andrey Abramov wrote: > Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files Please ignore the warnings for now. The RAID56 needs more cleanups than that an the sysfs part needs to be reworked. The stale code comes from e410e34fad913dd568ec

Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings

2019-05-31 Thread Andrey Abramov
31.05.2019, 23:05, "Joe Perches" : > On Fri, 2019-05-31 at 22:53 +0300, Andrey Abramov wrote: >>  Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files > These uses seem boolean, so perhaps just use bool? I used int because you use ints (as bools) everywhere (for example there is

Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings

2019-05-31 Thread Joe Perches
On Fri, 2019-05-31 at 23:31 +0300, Andrey Abramov wrote: > 31.05.2019, 23:05, "Joe Perches" : > > On Fri, 2019-05-31 at 22:53 +0300, Andrey Abramov wrote: > > > Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files > > These uses seem boolean, so perhaps just use bool? > I used int

Re: [PATCH] btrfs: Fix -Wunused-but-set-variable warnings

2019-05-31 Thread Joe Perches
On Fri, 2019-05-31 at 22:53 +0300, Andrey Abramov wrote: > Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files trivia: > diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c > index f3d0576dd327..4ab29eacfdf3 100644 > --- a/fs/btrfs/raid56.c > +++ b/fs/btrfs/raid56.c > @@ -1182,22

[PATCH] btrfs: Fix -Wunused-but-set-variable warnings

2019-05-31 Thread Andrey Abramov
Fix -Wunused-but-set-variable warnings in raid56.c and sysfs.c files Signed-off-by: Andrey Abramov --- fs/btrfs/raid56.c | 32 +++- fs/btrfs/sysfs.c | 5 + 2 files changed, 12 insertions(+), 25 deletions(-) diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c ind