Re: [PATCH] btrfs: Handle ENOMEM gracefully in cow_file_range_async

2019-01-25 Thread Filipe Manana
On Fri, Jan 25, 2019 at 3:08 PM David Sterba wrote: > > On Wed, Jan 09, 2019 at 04:43:03PM +0200, Nikolay Borisov wrote: > > If we run out of memory during delalloc filling in compress case btrfs > > is going to BUG_ON. This is unnecessary since the higher levels code > > (btrfs_run_delalloc_range

Re: [PATCH] btrfs: Handle ENOMEM gracefully in cow_file_range_async

2019-01-25 Thread Nikolay Borisov
On 25.01.19 г. 17:05 ч., David Sterba wrote: > On Wed, Jan 09, 2019 at 04:43:03PM +0200, Nikolay Borisov wrote: >> If we run out of memory during delalloc filling in compress case btrfs >> is going to BUG_ON. This is unnecessary since the higher levels code >> (btrfs_run_delalloc_range and its c

Re: [PATCH] btrfs: Handle ENOMEM gracefully in cow_file_range_async

2019-01-25 Thread David Sterba
On Wed, Jan 09, 2019 at 04:43:03PM +0200, Nikolay Borisov wrote: > If we run out of memory during delalloc filling in compress case btrfs > is going to BUG_ON. This is unnecessary since the higher levels code > (btrfs_run_delalloc_range and its callers) gracefully handle error > condtions and error

Re: [PATCH] btrfs: Handle ENOMEM gracefully in cow_file_range_async

2019-01-23 Thread Nikolay Borisov
On 9.01.19 г. 16:43 ч., Nikolay Borisov wrote: > If we run out of memory during delalloc filling in compress case btrfs > is going to BUG_ON. This is unnecessary since the higher levels code > (btrfs_run_delalloc_range and its callers) gracefully handle error > condtions and error out the page b

Re: [PATCH] btrfs: Handle ENOMEM gracefully in cow_file_range_async

2019-01-09 Thread Johannes Thumshirn
On 09/01/2019 15:43, Nikolay Borisov wrote: > If we run out of memory during delalloc filling in compress case btrfs > is going to BUG_ON. This is unnecessary since the higher levels code > (btrfs_run_delalloc_range and its callers) gracefully handle error > condtions and error out the page being s

[PATCH] btrfs: Handle ENOMEM gracefully in cow_file_range_async

2019-01-09 Thread Nikolay Borisov
If we run out of memory during delalloc filling in compress case btrfs is going to BUG_ON. This is unnecessary since the higher levels code (btrfs_run_delalloc_range and its callers) gracefully handle error condtions and error out the page being submittede. Let's be a model kernel citizen and no pa