Re: [PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2018-04-16 Thread Josef Bacik
On Sat, Apr 14, 2018 at 02:49:52AM +0200, David Sterba wrote: > On Fri, Apr 13, 2018 at 04:28:55PM -0400, Josef Bacik wrote: > > From: Josef Bacik > > > > Since we're allocating under atomic we could every easily enomem, so if > > that's the case and we can block then loop around and try to alloc

Re: [PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2018-04-13 Thread David Sterba
On Fri, Apr 13, 2018 at 04:28:55PM -0400, Josef Bacik wrote: > From: Josef Bacik > > Since we're allocating under atomic we could every easily enomem, so if > that's the case and we can block then loop around and try to allocate > the prealloc not under a lock. > > We also saw this happen during

Re: [PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2018-04-13 Thread Josef Bacik
On Fri, Apr 13, 2018 at 04:52:25PM -0700, Liu Bo wrote: > On Fri, Apr 13, 2018 at 1:28 PM, Josef Bacik wrote: > > From: Josef Bacik > > > > Since we're allocating under atomic we could every easily enomem, so if > > that's the case and we can block then loop around and try to allocate > > the pre

Re: [PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2018-04-13 Thread Liu Bo
On Fri, Apr 13, 2018 at 1:28 PM, Josef Bacik wrote: > From: Josef Bacik > > Since we're allocating under atomic we could every easily enomem, so if > that's the case and we can block then loop around and try to allocate > the prealloc not under a lock. > > We also saw this happen during try_to_re

[PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2018-04-13 Thread Josef Bacik
From: Josef Bacik Since we're allocating under atomic we could every easily enomem, so if that's the case and we can block then loop around and try to allocate the prealloc not under a lock. We also saw this happen during try_to_release_page in production, in which case it's completely valid to

Re: [PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2017-11-30 Thread David Sterba
On Fri, Nov 10, 2017 at 09:38:01AM +0200, Nikolay Borisov wrote: > On 9.11.2017 19:53, Josef Bacik wrote: > > From: Josef Bacik > > > > Since we're allocating under atomic we could every easily enomem, so if > > that's the case and we can block then loop around and try to allocate > > the preall

Re: [PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2017-11-09 Thread Nikolay Borisov
On 9.11.2017 19:53, Josef Bacik wrote: > From: Josef Bacik > > Since we're allocating under atomic we could every easily enomem, so if > that's the case and we can block then loop around and try to allocate > the prealloc not under a lock. > > We also saw this happen during try_to_release_pag

[PATCH] btrfs: don't bug_on with enomem in __clear_state_bit

2017-11-09 Thread Josef Bacik
From: Josef Bacik Since we're allocating under atomic we could every easily enomem, so if that's the case and we can block then loop around and try to allocate the prealloc not under a lock. We also saw this happen during try_to_release_page in production, in which case it's completely valid to