Re: [PATCH] btrfs: extent-tree: Use round up to replace align macro

2017-11-21 Thread Qu Wenruo
On 2017年11月21日 21:36, David Sterba wrote: > On Tue, Nov 21, 2017 at 01:54:45PM +0800, Qu Wenruo wrote: >> To save reader seconds before checking if it's rounding up or down. > > Agreed, this is more clear. Please switch all instances of ALIGN to > round_up, there's not much point doing it file b

Re: [PATCH] btrfs: extent-tree: Use round up to replace align macro

2017-11-21 Thread David Sterba
On Tue, Nov 21, 2017 at 04:06:54PM +0800, Qu Wenruo wrote: > On 2017年11月21日 15:33, Nikolay Borisov wrote: > > On 21.11.2017 07:54, Qu Wenruo wrote: > >> @@ -2054,7 +2054,7 @@ static int btrfs_issue_discard(struct block_device > >> *bdev, u64 start, u64 len, > >> { > >>int j, ret = 0; > >>

Re: [PATCH] btrfs: extent-tree: Use round up to replace align macro

2017-11-21 Thread David Sterba
On Tue, Nov 21, 2017 at 01:54:45PM +0800, Qu Wenruo wrote: > To save reader seconds before checking if it's rounding up or down. Agreed, this is more clear. Please switch all instances of ALIGN to round_up, there's not much point doing it file by file. -- To unsubscribe from this list: send the li

Re: [PATCH] btrfs: extent-tree: Use round up to replace align macro

2017-11-21 Thread Qu Wenruo
On 2017年11月21日 15:33, Nikolay Borisov wrote: > > > On 21.11.2017 07:54, Qu Wenruo wrote: >> To save reader seconds before checking if it's rounding up or down. >> >> Signed-off-by: Qu Wenruo >> --- >> fs/btrfs/extent-tree.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) >

Re: [PATCH] btrfs: extent-tree: Use round up to replace align macro

2017-11-20 Thread Nikolay Borisov
On 21.11.2017 07:54, Qu Wenruo wrote: > To save reader seconds before checking if it's rounding up or down. > > Signed-off-by: Qu Wenruo > --- > fs/btrfs/extent-tree.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-

[PATCH] btrfs: extent-tree: Use round up to replace align macro

2017-11-20 Thread Qu Wenruo
To save reader seconds before checking if it's rounding up or down. Signed-off-by: Qu Wenruo --- fs/btrfs/extent-tree.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 309a109069f1..8ab18e25cb91 100644 --- a/fs/