Re: [PATCH] btrfs: fix a compiler warning of may be used uninitialized

2015-09-30 Thread David Sterba
On Wed, Sep 30, 2015 at 11:55:13AM +0800, Zhao Lei wrote: > > AFAICS the codepath that would use uninitialized value of count is not > > reachable: > > > > add_to_ctl = true > > > > 270 if (info->offset > root->ino_cache_progress) > > 271 ad

Re: [PATCH] btrfs: fix a compiler warning of may be used uninitialized

2015-09-30 Thread Holger Hoffstätte
On 09/30/15 05:55, Zhao Lei wrote: >> count is defined iff add_to_ctl == true, so the patch is not necessary. And >> I'm >> not quite sure that 0 passed down to __btrfs_add_free_space as 'bytes' makes >> sense at all. > > Agree above all. > > So I write following description in changelog: > "N

RE: [PATCH] btrfs: fix a compiler warning of may be used uninitialized

2015-09-29 Thread Zhao Lei
Hi, David Sterba Thanks for reviewing. > -Original Message- > From: David Sterba [mailto:dste...@suse.cz] > Sent: Tuesday, September 29, 2015 10:22 PM > To: Zhao Lei > Cc: linux-btrfs@vger.kernel.org > Subject: Re: [PATCH] btrfs: fix a compiler warning of may be use

Re: [PATCH] btrfs: fix a compiler warning of may be used uninitialized

2015-09-29 Thread David Sterba
On Wed, Sep 02, 2015 at 03:19:59PM +0800, Zhao Lei wrote: > Not real problem, just avoid warning of: > fs/btrfs/inode-map.c: In function 'btrfs_unpin_free_ino': > fs/btrfs/inode-map.c:252: warning: 'count' may be used uninitialized in this > function > In gcc 4.8.3 > > Signed-off-by: Zhao Lei

[PATCH] btrfs: fix a compiler warning of may be used uninitialized

2015-09-02 Thread Zhao Lei
Not real problem, just avoid warning of: fs/btrfs/inode-map.c: In function 'btrfs_unpin_free_ino': fs/btrfs/inode-map.c:252: warning: 'count' may be used uninitialized in this function In gcc 4.8.3 Signed-off-by: Zhao Lei --- fs/btrfs/inode-map.c | 2 +- 1 file changed, 1 insertion(+), 1 dele