Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-09-07 Thread David Sterba
On Fri, Sep 02, 2011 at 08:01:21PM +0300, sly...@gmail.com wrote: From: Sergei Trofimovich sly...@gentoo.org iput() shouldn't be called for inodes in I_NEW state. We need to mark inode as constructed first. WARNING: at fs/inode.c:1309 iput+0x20b/0x210() Call Trace: [8103e7ba]

[PATCH] btrfs: fix warning in iput for bad-inode

2011-09-02 Thread slyich
From: Sergei Trofimovich sly...@gentoo.org iput() shouldn't be called for inodes in I_NEW state. We need to mark inode as constructed first. WARNING: at fs/inode.c:1309 iput+0x20b/0x210() Call Trace: [8103e7ba] warn_slowpath_common+0x7a/0xb0 [8103e805]

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-30 Thread Sergei Trofimovich
Running 'sync' program after the load does not finish and eats 100%CPU busy-waiting for something in kernel. It's easy to reproduce hang with patch for me. I just run liferea and sync after it. Without patch I haven't managed to hang btrfs up. And I think it's another btrfs bug. I've

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-30 Thread Josef Bacik
On 08/30/2011 12:53 PM, Sergei Trofimovich wrote: Running 'sync' program after the load does not finish and eats 100%CPU busy-waiting for something in kernel. It's easy to reproduce hang with patch for me. I just run liferea and sync after it. Without patch I haven't managed to hang btrfs

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-30 Thread Sergei Trofimovich
On Tue, 30 Aug 2011 14:02:37 -0400 Josef Bacik jo...@redhat.com wrote: On 08/30/2011 12:53 PM, Sergei Trofimovich wrote: Running 'sync' program after the load does not finish and eats 100%CPU busy-waiting for something in kernel. It's easy to reproduce hang with patch for me. I just

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-30 Thread Josef Bacik
On 08/30/2011 03:31 PM, Sergei Trofimovich wrote: On Tue, 30 Aug 2011 14:02:37 -0400 Josef Bacik jo...@redhat.com wrote: On 08/30/2011 12:53 PM, Sergei Trofimovich wrote: Running 'sync' program after the load does not finish and eats 100%CPU busy-waiting for something in kernel. It's

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-30 Thread Josef Bacik
On 08/30/2011 03:40 PM, Josef Bacik wrote: On 08/30/2011 03:31 PM, Sergei Trofimovich wrote: On Tue, 30 Aug 2011 14:02:37 -0400 Josef Bacik jo...@redhat.com wrote: On 08/30/2011 12:53 PM, Sergei Trofimovich wrote: Running 'sync' program after the load does not finish and eats 100%CPU

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-30 Thread Sergei Trofimovich
On 08/30/2011 03:40 PM, Josef Bacik wrote: On 08/30/2011 03:31 PM, Sergei Trofimovich wrote: On Tue, 30 Aug 2011 14:02:37 -0400 Josef Bacik jo...@redhat.com wrote: On 08/30/2011 12:53 PM, Sergei Trofimovich wrote: Running 'sync' program after the load does not finish and eats

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-30 Thread Sergei Trofimovich
About the second one: ==The Second Issue (aka The Busy Looping sync() case) == The box is different from first, so conditions are a bit different. - /dev/root on / type btrfs (rw,noatime,autodefrag) (note autodefrag!) - 15% full 594GB filesystem (usual nonmixed mode) $

Re: [PATCH] btrfs: fix warning in iput for bad-inode

2011-08-28 Thread Sergei Trofimovich
On Wed, 17 Aug 2011 22:56:19 +0400 Konstantin Khlebnikov khlebni...@openvz.org wrote: iput() shouldn't be called for inodes in I_NEW state, lets call __destroy_inode() and btrfs_destroy_inode() instead Hi Konstantin! Running 'sync' program after the load does not finish and eats 100%CPU

[PATCH] btrfs: fix warning in iput for bad-inode

2011-08-17 Thread Konstantin Khlebnikov
iput() shouldn't be called for inodes in I_NEW state, lets call __destroy_inode() and btrfs_destroy_inode() instead [1.871723] WARNING: at fs/inode.c:1309 iput+0x1d9/0x200() [1.873722] Modules linked in: [1.873722] Pid: 1, comm: swapper Tainted: GW 3.1.0-rc2-zurg #58 [