Re: [PATCH] btrfs: make block group flags in balance printks human-readable

2016-11-07 Thread Adam Borowski
On Mon, Nov 07, 2016 at 05:58:41PM +0100, David Sterba wrote: > On Fri, Nov 04, 2016 at 08:26:54AM +0100, Adam Borowski wrote: > > They're not even documented anywhere, letting users with no recourse but > > to RTFS. It's no big burden to output the bitfield as words. > > Ok. Below are some comme

Re: [PATCH] btrfs: make block group flags in balance printks human-readable

2016-11-07 Thread David Sterba
On Fri, Nov 04, 2016 at 08:26:54AM +0100, Adam Borowski wrote: > They're not even documented anywhere, letting users with no recourse but > to RTFS. It's no big burden to output the bitfield as words. Ok. Below are some comments (and style nitpicks). > Also, display unknown flags as hex. > > Si

Re: [PATCH] btrfs: make block group flags in balance printks human-readable

2016-11-07 Thread Holger Hoffstätte
On 11/04/16 08:26, Adam Borowski wrote: > They're not even documented anywhere, letting users with no recourse but > to RTFS. It's no big burden to output the bitfield as words. > > Also, display unknown flags as hex. > > Signed-off-by: Adam Borowski Very helpful and works (for me) as advertis

[PATCH] btrfs: make block group flags in balance printks human-readable

2016-11-04 Thread Adam Borowski
They're not even documented anywhere, letting users with no recourse but to RTFS. It's no big burden to output the bitfield as words. Also, display unknown flags as hex. Signed-off-by: Adam Borowski --- fs/btrfs/relocation.c | 34 -- 1 file changed, 32 insertion