Re: [PATCH] btrfs: remove WARN_ON() in log_dir_items

2019-03-07 Thread David Sterba
On Wed, Mar 06, 2019 at 05:13:04PM -0500, Josef Bacik wrote: > When Filipe added the recursive directory logging stuff he specifically > didn't take the directory i_mutex for the children directories that we > need to log because of lockdep. This is generally fine, but can lead to > this WARN_ON()

Re: [PATCH] btrfs: remove WARN_ON() in log_dir_items

2019-03-07 Thread Filipe Manana
On Wed, Mar 6, 2019 at 10:15 PM Josef Bacik wrote: > > When Filipe added the recursive directory logging stuff he specifically > didn't take the directory i_mutex for the children directories that we > need to log because of lockdep. This is generally fine, but can lead to > this WARN_ON() trippi

[PATCH] btrfs: remove WARN_ON() in log_dir_items

2019-03-06 Thread Josef Bacik
When Filipe added the recursive directory logging stuff he specifically didn't take the directory i_mutex for the children directories that we need to log because of lockdep. This is generally fine, but can lead to this WARN_ON() tripping if we happen to run delayed deletion's in between our first