Re: [PATCH] btrfs: remove unnecessary btrfs_delalloc_release_metadata() call

2016-05-19 Thread Wang Xiaoguang
Hi, On 05/19/2016 06:29 PM, Filipe Manana wrote: On Thu, May 19, 2016 at 10:44 AM, Wang Xiaoguang wrote: In __btrfs_write_out_cache(), we don't call btrfs_delalloc_reserve_metadata() or btrfs_delalloc_reserve_space() to reserve metadata space, so we also should not call btrfs_delalloc_release_

Re: [PATCH] btrfs: remove unnecessary btrfs_delalloc_release_metadata() call

2016-05-19 Thread Filipe Manana
On Thu, May 19, 2016 at 10:44 AM, Wang Xiaoguang wrote: > In __btrfs_write_out_cache(), we don't call btrfs_delalloc_reserve_metadata() > or btrfs_delalloc_reserve_space() to reserve metadata space, so we also should > not call btrfs_delalloc_release_metadata(), in which > BTRFS_I(inode)->outstan

[PATCH] btrfs: remove unnecessary btrfs_delalloc_release_metadata() call

2016-05-19 Thread Wang Xiaoguang
In __btrfs_write_out_cache(), we don't call btrfs_delalloc_reserve_metadata() or btrfs_delalloc_reserve_space() to reserve metadata space, so we also should not call btrfs_delalloc_release_metadata(), in which BTRFS_I(inode)->outstanding_extents will be decreased, then WARN_ON(BTRFS_I(inode)->outs