Re: [PATCH] btrfs: take the error path out if btrfs_attach_transaction() fails

2017-09-29 Thread David Sterba
On Thu, Sep 28, 2017 at 03:13:06PM +0800, Anand Jain wrote: > > I'd suggest to first get rid of the in-place returns and add necessary > > labels or separate exit sequences and then address the new error > > handling. > >As it goes deeper there are quite a number of things which aren't >un

Re: [PATCH] btrfs: take the error path out if btrfs_attach_transaction() fails

2017-09-28 Thread Anand Jain
On 09/27/2017 10:17 PM, David Sterba wrote: On Wed, Sep 27, 2017 at 05:50:52PM +0800, Anand Jain wrote: btrfs_init_new_device() calls btrfs_attach_transaction() to commit sys chunks, however take the error path out if it fails. Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 3 ++- 1 f

Re: [PATCH] btrfs: take the error path out if btrfs_attach_transaction() fails

2017-09-27 Thread David Sterba
On Wed, Sep 27, 2017 at 05:50:52PM +0800, Anand Jain wrote: > btrfs_init_new_device() calls btrfs_attach_transaction() to > commit sys chunks, however take the error path out if it fails. > > Signed-off-by: Anand Jain > --- > fs/btrfs/volumes.c | 3 ++- > 1 file changed, 2 insertions(+), 1 delet

Re: [PATCH] btrfs: take the error path out if btrfs_attach_transaction() fails

2017-09-27 Thread Qu Wenruo
On 2017年09月27日 17:50, Anand Jain wrote: btrfs_init_new_device() calls btrfs_attach_transaction() to commit sys chunks, however take the error path out if it fails. Signed-off-by: Anand Jain Reviewed-by: Qu Wenruo Thanks, Qu --- fs/btrfs/volumes.c | 3 ++- 1 file changed, 2 insertions

[PATCH] btrfs: take the error path out if btrfs_attach_transaction() fails

2017-09-27 Thread Anand Jain
btrfs_init_new_device() calls btrfs_attach_transaction() to commit sys chunks, however take the error path out if it fails. Signed-off-by: Anand Jain --- fs/btrfs/volumes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index fad3b10