Re: [PATCH] btrfs: test snapshot create with invalid parent qgroup

2016-04-07 Thread Filipe Manana
t; > http://thread.gmane.org/gmane.comp.file-systems.btrfs/54755 >> > >> > Thanks, >> > --Mark >> > >> > Signed-off-by: Mark Fasheh >> >> Reviewed-by: Filipe Manana >> >> Looks good, just a few minor notes below. >

Re: [PATCH] btrfs: test snapshot create with invalid parent qgroup

2016-04-06 Thread Mark Fasheh
> > Signed-off-by: Mark Fasheh > > Reviewed-by: Filipe Manana > > Looks good, just a few minor notes below. Thanks for the review Filipe. How's this look? --Mark -- Mark Fasheh From: Mark Fasheh [PATCH] btrfs: test s

Re: [PATCH] btrfs: test snapshot create with invalid parent qgroup

2016-04-06 Thread Filipe Manana
On Wed, Apr 6, 2016 at 10:30 PM, Mark Fasheh wrote: > Test that an invalid parent qgroup does not cause snapshot create to > force the FS readonly. > > In btrfs, create_pending_snapshot() will go readonly on _any_ error return > from > btrfs_qgroup_inherit(). If qgroups are enabled, a user can cr

Re: [PATCH] btrfs: test snapshot create with invalid parent qgroup

2016-04-06 Thread Mark Fasheh
patch relates to can be found at the following url: > http://thread.gmane.org/gmane.comp.file-systems.btrfs/54755 > > Thanks, > --Mark > > Signed-off-by: Mark Fasheh Oops, wrong patch was attached. This is a version that actually works :) --Mark -- Mark Fasheh [

[PATCH] btrfs: test snapshot create with invalid parent qgroup

2016-04-06 Thread Mark Fasheh
Test that an invalid parent qgroup does not cause snapshot create to force the FS readonly. In btrfs, create_pending_snapshot() will go readonly on _any_ error return from btrfs_qgroup_inherit(). If qgroups are enabled, a user can crash their fs by just making a snapshot and asking it to inherit f