On Tue, Jun 23, 2015 at 02:30:06PM -0700, Omar Sandoval wrote:
> > No need to introduce the wrappers, it's enough to add an alternative
> > usage string and the callback function will be the same. Also please
> > keep the aliased entries next to each other.
>
> So the reason I did that way is that
On Tue, Jun 23, 2015 at 05:40:39PM +0200, David Sterba wrote:
> On Thu, Jun 18, 2015 at 03:07:09PM -0700, Omar Sandoval wrote:
> > @@ -586,12 +606,13 @@ out:
> > const struct cmd_group device_cmd_group = {
> > device_cmd_group_usage, NULL, {
> > { "add", cmd_add_dev, cmd_add_dev_us
On Thu, Jun 18, 2015 at 03:07:09PM -0700, Omar Sandoval wrote:
> @@ -586,12 +606,13 @@ out:
> const struct cmd_group device_cmd_group = {
> device_cmd_group_usage, NULL, {
> { "add", cmd_add_dev, cmd_add_dev_usage, NULL, 0 },
> - { "delete", cmd_rm_dev, cmd_rm_dev_u
There's an awkward asymmetry between btrfs device add and btrfs device
delete. Resolve this by aliasing delete to remove.
Signed-off-by: Omar Sandoval
---
Documentation/btrfs-device.asciidoc | 5 -
cmds-device.c | 33 +++--
2 files changed,
