Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-05-09 Thread Lakshmipathi.G
> > Does the mke2fs command exist on your system? We maybe want to use > mkfs.ext4 directly. Yes, mke2fs is there. (I'll check using mkfs.ext4 directly) # ./convert-tests/009-common-inode-flags/test.sh [TEST/conv] common inode flags test, btrfs defaults failed: mke2fs -t ext4 -b 4096 -F /

Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-05-09 Thread David Sterba
On Tue, May 09, 2017 at 07:46:08PM +0530, Lakshmipathi.G wrote: > created a test script but it fail to detect mk2fs. Test script 009 > also produces: > > # ./convert-tests/009-common-inode-flags/test.sh > [TEST/conv] common inode flags test, btrfs defaults > failed: mke2fs -t ext4 -b 4096

Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-05-09 Thread Lakshmipathi.G
created a test script but it fail to detect mk2fs. Test script 009 also produces: # ./convert-tests/009-common-inode-flags/test.sh [TEST/conv] common inode flags test, btrfs defaults failed: mke2fs -t ext4 -b 4096 -F /home/laks/centos/laks/BTRFS/btrfs-progs/tests/test.img Seems like run_c

Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-05-03 Thread Lakshmipathi.G
> file is ~160MB. This sounds much better. So please write a test, using > something like > > truncate -s3T image > mkfs.ext4 image > mount && write some data > convert && rollback > > Thanks. Later we might need to add some mkfs.ext4 option coverage. Sure, will send the above test script in upc

Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-05-02 Thread David Sterba
On Tue, May 02, 2017 at 05:06:01PM +0200, David Sterba wrote: > On Thu, Apr 27, 2017 at 03:35:34PM +0530, Lakshmipathi.G wrote: > > Bug: Fail to convert 22TB EXT4 to BTRFS > > https://bugzilla.kernel.org/show_bug.cgi?id=194795 > > Thanks for working on the bug, the proposed fix looks good to me ju

Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-05-02 Thread Lakshmipathi.G
On Tue, May 02, 2017 at 05:06:01PM +0200, David Sterba wrote: > On Thu, Apr 27, 2017 at 03:35:34PM +0530, Lakshmipathi.G wrote: > > Bug: Fail to convert 22TB EXT4 to BTRFS > > https://bugzilla.kernel.org/show_bug.cgi?id=194795 > > Thanks for working on the bug, the proposed fix looks good to me ju

Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-05-02 Thread David Sterba
On Thu, Apr 27, 2017 at 03:35:34PM +0530, Lakshmipathi.G wrote: > Bug: Fail to convert 22TB EXT4 to BTRFS > https://bugzilla.kernel.org/show_bug.cgi?id=194795 Thanks for working on the bug, the proposed fix looks good to me judging by the use of extended API. This would need a test though. I'm try

Re: [PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-04-27 Thread Lakshmipathi.G
Hi Qu, Seems like its a known issue with older bitmaps. http://linux-ext4.vger.kernel.narkive.com/wkNbJe0b/patch-debugfs-open-with-ext2-flag-64bits Cheers. Lakshmipathi.G On Fri, Apr 28, 2017 at 09:48:10AM +0800, Qu Wenruo wrote: > > > At 04/28/2017 09:27 AM, Qu Wenruo wrote: > >At 04/27/2017

[PATCH] btrfs-progs: btrfs-convert: Add larger device support

2017-04-27 Thread Lakshmipathi.G
Bug: Fail to convert 22TB EXT4 to BTRFS https://bugzilla.kernel.org/show_bug.cgi?id=194795 Signed-off-by: Lakshmipathi.G --- convert/source-ext2.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/convert/source-ext2.c b/convert/source-ext2.c index 1b0576b..275cb89