Re: [PATCH] btrfs-progs: check: Fix heap use after free.

2017-05-03 Thread David Sterba
On Wed, May 03, 2017 at 09:50:14AM +0800, Su Yue wrote: > While iterating over backrefs in repair_inode_backrefs, there are several > situations to repair one backref according backref->found_dir_item and > backref->found_dir_index. > Two of these branches may free the backref, but next judgments w

[PATCH] btrfs-progs: check: Fix heap use after free.

2017-05-02 Thread Su Yue
fsck/004-no-dir-index makes valgrinds complaining about Invalid read. ==31890== Invalid read of size 1 ==31890==at 0x453D09: repair_inode_backrefs (cmds-check.c:2690) ==31890==by 0x453D09: check_inode_recs (cmds-check.c:3330) ==31890==by 0x453D09: check_fs_root (cmds-check.c:4012) ==318

Re: [PATCH] btrfs-progs: check: Fix heap use after free.

2017-05-02 Thread David Sterba
On Tue, May 02, 2017 at 02:26:19PM +0800, Su Yue wrote: > The repair_inode_backrefs use the backref again after free while iterating > over backrefs. > So let it continue to next step after free can fix it. Please enhance the changelog. I'm missing some explanation that the new code is still corr

[PATCH] btrfs-progs: check: Fix heap use after free.

2017-05-01 Thread Su Yue
fsck/004-no-dir-index makes valgrinds complaining about Invalid read. ==31890== Invalid read of size 1 ==31890==at 0x453D09: repair_inode_backrefs (cmds-check.c:2690) ==31890==by 0x453D09: check_inode_recs (cmds-check.c:3330) ==31890==by 0x453D09: check_fs_root (cmds-check.c:4012) ==318