Re: [PATCH] btrfs-progs: read global reserve size from space infos

2014-04-23 Thread David Sterba
On Tue, Apr 22, 2014 at 05:12:34PM +0200, Xavier Bassery wrote: Global_rsv or GlobalRsv or Globalrsv or something else? Personally, I'd probably go for the camel case GlobalRsv, or possibly GlbReserve. (Assuming that it's going to be only a single token without whitespace to make

Re: [PATCH] btrfs-progs: read global reserve size from space infos

2014-04-23 Thread Chris Mason
On 04/23/2014 09:30 AM, David Sterba wrote: On Tue, Apr 22, 2014 at 05:12:34PM +0200, Xavier Bassery wrote: Global_rsv or GlobalRsv or Globalrsv or something else? Personally, I'd probably go for the camel case GlobalRsv, or possibly GlbReserve. (Assuming that it's going to be only a

[PATCH] btrfs-progs: read global reserve size from space infos

2014-04-22 Thread David Sterba
Kernels 3.15 export the global block reserve as a space info presented by 'btrfs fi df' but would display 'unknown' instead of some meaningful string. Signed-off-by: David Sterba dste...@suse.cz --- Global_rsv or GlobalRsv or Globalrsv or something else? cmds-filesystem.c | 2 ++ ctree.h

Re: [PATCH] btrfs-progs: read global reserve size from space infos

2014-04-22 Thread Hugo Mills
On Tue, Apr 22, 2014 at 03:20:00PM +0200, David Sterba wrote: Kernels 3.15 export the global block reserve as a space info presented by 'btrfs fi df' but would display 'unknown' instead of some meaningful string. Signed-off-by: David Sterba dste...@suse.cz --- Global_rsv or GlobalRsv or

Re: [PATCH] btrfs-progs: read global reserve size from space infos

2014-04-22 Thread Xavier Bassery
On Tue, 22 Apr 2014 15:09:00 +0100 Hugo Mills h...@carfax.org.uk wrote: On Tue, Apr 22, 2014 at 03:20:00PM +0200, David Sterba wrote: Kernels 3.15 export the global block reserve as a space info presented by 'btrfs fi df' but would display 'unknown' instead of some meaningful string.