Re: [PATCH] btrfs-progs: readahead errors are not fatal

2014-08-29 Thread David Sterba
On Wed, Aug 27, 2014 at 11:16:03AM -0700, Zach Brown wrote: > Seems like this is already leaking a refcount and only returns 0.. so > maybe remove the bug_on something like this totally untested patch? Looks much better than my patch, I'm taking it. > There's another "#if 0"-ed out caller in ext

Re: [PATCH] btrfs-progs: readahead errors are not fatal

2014-08-27 Thread Zach Brown
On Wed, Aug 27, 2014 at 07:47:45PM +0200, David Sterba wrote: > Kill the BUG_ON. > > Signed-off-by: David Sterba > --- > disk-io.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/disk-io.c b/disk-io.c > index 8db0335bc81b..7ddd4b90836f 100644 > --- a/disk-io.c > +++ b

[PATCH] btrfs-progs: readahead errors are not fatal

2014-08-27 Thread David Sterba
Kill the BUG_ON. Signed-off-by: David Sterba --- disk-io.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/disk-io.c b/disk-io.c index 8db0335bc81b..7ddd4b90836f 100644 --- a/disk-io.c +++ b/disk-io.c @@ -152,7 +152,8 @@ int readahead_tree_block(struct btrfs_root *root, u64