Got it. Thanks for the clarification.
signature.asc
Description: Digital signature
On Thu, Feb 21, 2019 at 02:57:27PM +, Dan Robertson wrote:
> > Thanks, it's been there since the first merge of scrub, but hard to hit.
>
> Yeah, very hard to hit. Debated submitting a patch, but the fix seemed
> simple enough, so figured I'd send one in.
>
> Side note: I noticed most of the
> Thanks, it's been there since the first merge of scrub, but hard to hit.
Yeah, very hard to hit. Debated submitting a patch, but the fix seemed
simple enough, so figured I'd send one in.
Side note: I noticed most of the time ENOMEM is hit in fs/btrfs BUG or BUG_ON is
called. Would it be better
On Tue, Feb 19, 2019 at 02:56:43AM +, Dan Robertson wrote:
> The scrub_ctx csum_list member must be initialized before
> scrub_free_ctx is called. If the csum_list is not initialized
> beforehand, the list_empty call in scrub_free_csums will result
> in a null deref.
>
> Signed-off-by: Dan Rob
On 19.02.19 г. 4:56 ч., Dan Robertson wrote:
> The scrub_ctx csum_list member must be initialized before
> scrub_free_ctx is called. If the csum_list is not initialized
> beforehand, the list_empty call in scrub_free_csums will result
> in a null deref.
>
> Signed-off-by: Dan Robertson
Review
The scrub_ctx csum_list member must be initialized before
scrub_free_ctx is called. If the csum_list is not initialized
beforehand, the list_empty call in scrub_free_csums will result
in a null deref.
Signed-off-by: Dan Robertson
---
fs/btrfs/scrub.c | 2 +-
1 file changed, 1 insertion(+), 1 del
